Changes between Initial Version and Version 1 of Ticket #57635, comment 16
- Timestamp:
- 06/05/2025 02:26:09 PM (8 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #57635, comment 16
initial v1 1 Test this at WordCamp Europe 2025 using WordPress playground and recorded 2 videos of the tests.1 Tested this at WordCamp Europe 2025 using WordPress playground and recorded 2 videos of the tests. 2 2 3 Before the fix we can observe that a user is successfully created with an empty user_nicenamewhich results in the author page link leading to a 404. https://www.loom.com/share/f23eabfc48974f04919c9ed827ad5126?sid=9f58298e-ae09-4e7a-bba4-3aa9017263473 Before the fix we can observe that a user is successfully created with an empty `user_nicename` which results in the author page link leading to a 404. https://www.loom.com/share/f23eabfc48974f04919c9ed827ad5126?sid=9f58298e-ae09-4e7a-bba4-3aa901726347 4 4 5 After the fix we can observe that if a user's user_nicenamewould be empty then no user is created and an appropriate error is returned. https://www.loom.com/share/1d1d9881694e453b870a056bed43ab6c?sid=1c7f0090-8dab-48e8-9a46-0772e096ea835 After the fix we can observe that if a user's `user_nicename` would be empty then no user is created and an appropriate error is returned. https://www.loom.com/share/1d1d9881694e453b870a056bed43ab6c?sid=1c7f0090-8dab-48e8-9a46-0772e096ea83 6 6 7 7 Based on these results and a review of the code in the pull request, I've approved the pull request.