Make WordPress Core

Opened 17 years ago

Closed 17 years ago

#5764 closed defect (bug) (fixed)

No way to upload if you don't use visual editor

Reported by: jhodgdon's profile jhodgdon Owned by: ryan's profile ryan
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: Administration Keywords: has-patch
Focuses: Cc:

Description (last modified by lloydbudd)

In [6713], if you uncheck the box in your user profile that says "Use the visual editor", there is apparently no way to upload files or other images on the Write/Edit Post screen.

Steps to reproduce: I am using Firefox 2.0 on Windows. I log in as administrative user in my test blog. Click on "Users", and edit my user profile. Uncheck the box saying "Use the visual editor when writing". Save profile. Click on "Write" to write a new post. There is no section on the screen that I can find that will allow me to upload files.

If I then go back to my profile and turn on the visual editor (which I normally do not use, because I prefer to write my own clean HTML), there is now an "Add media" section, even if I switch to the "code" editor tab.

ADDITIONAL DETAILS (from Ryan)

The problem is in the_editor(). media-buttons is defined within a user_can_richedit() conditional.

Attachments (2)

r6736_media_buttons.diff (634 bytes) - added by ffemtcj 17 years ago.
Fixes missing Add media when visual editor is not default
media-buttons-r6744.patch (666 bytes) - added by tellyworth 17 years ago.
alternate patch

Download all attachments as: .zip

Change History (8)

#1 @lloydbudd
17 years ago

jhodgdon, thank you for putting this in its own ticket!

Relates to #5609 New image uploader
nbachiyski, "If the user has disabled the visual editor from her profile, the Add media: bar isn't shown."

#2 @lloydbudd
17 years ago

  • Description modified (diff)

@ffemtcj
17 years ago

Fixes missing Add media when visual editor is not default

#3 @ffemtcj
17 years ago

  • Cc ffemtcj added
  • Keywords has-patch added; upload removed

#4 @ryan
17 years ago

  • Owner changed from anonymous to ryan

@tellyworth
17 years ago

alternate patch

#5 @tellyworth
17 years ago

Oops - didn't notice this ticket so I wound up fixing the same problem. Alternate patch included for whatever it's worth, no doubt the result is the same with both.

#6 @ryan
17 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6746]) Show media upload buttons when RTE is not enabled. Props tellyworth. fixes #5764

Note: See TracTickets for help on using tickets.