Make WordPress Core

Opened 17 months ago

Closed 17 months ago

Last modified 16 months ago

#57649 closed defect (bug) (fixed)

Revert appearance tools theme support

Reported by: poena's profile poena Owned by: davidbaumwald's profile davidbaumwald
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Themes Keywords: 2nd-opinion has-patch has-unit-tests add-to-field-guide
Focuses: Cc:

Description (last modified by poena)

The appearance tools theme support includes block gap, a feature that was not intended for themes without theme.json.

The feature does not work for themes without theme.json because they do not support layout settings and because of different HTML markup in the group block.

https://github.com/WordPress/gutenberg/pull/47451#issuecomment-1411373956

Until it has been determined if the feature can and should be enabled in these themes,
and has been successfully tested, the appearance tools theme support should be reverted.

Change History (13)

#1 @poena
17 months ago

  • Description modified (diff)

#2 @Mamaduka
17 months ago

I'm going to add a link to @poena's latest PRs. I think it summarized current problems with appearance-tools pretty well - https://github.com/WordPress/gutenberg/pull/47675#top.

This ticket was mentioned in Slack in #core-editor by mamaduka. View the logs.


17 months ago

#4 @scruffian
17 months ago

I think this is a good idea.

This ticket was mentioned in PR #4026 on WordPress/wordpress-develop by @Mamaduka.


17 months ago
#5

  • Keywords has-patch has-unit-tests added

Reverts changes from https://github.com/WordPress/wordpress-develop/pull/3846. See the core ticket for more details.

Trac ticket: https://core.trac.wordpress.org/ticket/57649

@Mamaduka commented on PR #4026:


17 months ago
#6

Thanks for the super-fast response, @audrasjb ⚡

#7 @davidbaumwald
17 months ago

  • Owner set to davidbaumwald
  • Status changed from new to accepted

#8 @jffng
17 months ago

I agree based on the testing and feedback it makes sense to revert this. Classic themes still have a way get design tools via adding theme.json and opting in explicitly.

#9 @davidbaumwald
17 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55273:

Themes: Revert appearance tools theme support.

The appearance tools theme support(merged in [55067]) includes block gap, a feature that was not intended for themes without a theme.json.

Until it has been determined if the feature can and should be enabled in these themes, and has been successfully tested, the appearance tools theme support should be reverted.

Reverts [55067].

Props poena, Mamaduka, audrasjb.
Fixes #57649.

@davidbaumwald commented on PR #4026:


17 months ago
#10

This PR is an exact copy of reverting https://core.trac.wordpress.org/changeset/55076, and that was done on trunk in https://core.trac.wordpress.org/changeset/55273. Closing this PR as "merged".

@Mamaduka commented on PR #4026:


17 months ago
#11

Thank you, @dream-encode!

@Mamaduka commented on PR #4026:


17 months ago
#12

Thank you, @dream-encode!

#13 @milana_cap
16 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.