#57649 closed defect (bug) (fixed)
Revert appearance tools theme support
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Themes | Keywords: | 2nd-opinion has-patch has-unit-tests add-to-field-guide |
Focuses: | Cc: |
Description (last modified by )
The appearance tools theme support includes block gap, a feature that was not intended for themes without theme.json.
The feature does not work for themes without theme.json because they do not support layout settings and because of different HTML markup in the group block.
https://github.com/WordPress/gutenberg/pull/47451#issuecomment-1411373956
Until it has been determined if the feature can and should be enabled in these themes,
and has been successfully tested, the appearance tools theme support should be reverted.
Change History (13)
This ticket was mentioned in Slack in #core-editor by mamaduka. View the logs.
2 years ago
This ticket was mentioned in PR #4026 on WordPress/wordpress-develop by @Mamaduka.
2 years ago
#5
- Keywords has-patch has-unit-tests added
Reverts changes from https://github.com/WordPress/wordpress-develop/pull/3846. See the core ticket for more details.
Trac ticket: https://core.trac.wordpress.org/ticket/57649
@Mamaduka commented on PR #4026:
2 years ago
#6
Thanks for the super-fast response, @audrasjb ⚡
#8
@
2 years ago
I agree based on the testing and feedback it makes sense to revert this. Classic themes still have a way get design tools via adding theme.json and opting in explicitly.
@davidbaumwald commented on PR #4026:
2 years ago
#10
This PR is an exact copy of reverting https://core.trac.wordpress.org/changeset/55076, and that was done on trunk in https://core.trac.wordpress.org/changeset/55273. Closing this PR as "merged".
@Mamaduka commented on PR #4026:
2 years ago
#11
Thank you, @dream-encode!
@Mamaduka commented on PR #4026:
2 years ago
#12
Thank you, @dream-encode!
I'm going to add a link to @poena's latest PRs. I think it summarized current problems with
appearance-tools
pretty well - https://github.com/WordPress/gutenberg/pull/47675#top.