WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#57654 closed enhancement (fixed)

Removing the beta label from the Site Editor

Reported by: priethor Owned by: audrasjb
Priority: normal Milestone: 6.2
Component: Administration Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

As @matveb mentioned in his ​post about finalizing Phase 2, the beta label should be removed from the Site Editor.

Attachments (1)

57654.followup.patch​ (444 bytes ) - added by joedolson 4 years ago.
Add to title tag

Download all attachments as: .zip

Change History (14)

This ticket was mentioned in ​PR #4024 on ​WordPress/wordpress-develop by ​@audrasjb.
4 years ago #1

  • Keywords has-patch added

https://core.trac.wordpress.org/ticket/57654

#2 @audrasjb
4 years ago

  • Component General → Administration

The above PR removes the "beta" label and adds a context for translators to make sure the Editor string is translated in the context of the WP-Admin menu item.

#3 @audrasjb
4 years ago

  • Owner set to audrasjb
  • Status new → accepted

​@audrasjb commented on ​PR #4024:
4 years ago #4

thanks tonya, let's roll!

#5 @hellofromTonya
4 years ago

  • Keywords commit added

Marking for commit.

#6 @audrasjb
4 years ago

  • Resolution → fixed
  • Status accepted → closed

In 55281:

Editor: Remove "beta" label from Site Editor submenu item.

One year later, the beta phase is finally over.

Props priethor, matveb, audrasjb, hellofromtonya.
Fixes #57654.

#8 follow-up: @kebbet
4 years ago

  • Resolution fixed
  • Status closed → reopened

Should the title for the <title> tag be adjusted too?

​https://github.com/WordPress/wordpress-develop/blob/85cd4a1e1ff32b03c8bd7b01c9d65609740624a7/src/wp-admin/site-editor.php#L49

Last edited 4 years ago by kebbet (previous) (diff)

This ticket was mentioned in ​Slack in #core by kebbet. ​View the logs.
4 years ago

#10 in reply to: ↑ 8 @hellofromTonya
4 years ago

  • Keywords needs-patch added; has-patch commit removed

Replying to kebbet:

Should the title for the <title> tag be adjusted too?

​https://github.com/WordPress/wordpress-develop/blob/85cd4a1e1ff32b03c8bd7b01c9d65609740624a7/src/wp-admin/site-editor.php#L49

Good catch @kebbet! Yes, it needs adjustment too. Resetting the keywords.

@joedolson
4 years ago

Add to title tag

#11 @joedolson
4 years ago

  • Keywords has-patch commit added; needs-patch removed

#12 @joedolson
4 years ago

  • Resolution → fixed
  • Status reopened → closed

In 55288:

Administration: Match title tag to menu item for Editor.

Removes 'beta' from the title element for the site editor. Follow up to [55281].

Props kebbet.
Fixes #57654.

#13 @annezazu
4 years ago

For greater historical context and to cross connect efforts, I wanted to note the original discussion and issue for removing the beta label in the Gutenberg GitHub repo for anyone curious for more information: ​https://github.com/WordPress/gutenberg/issues/39293 This was used as both a discussion and tracking spot for this decision before making its way to trac ahead of beta 1 for 6.2.

Note: See TracTickets for help on using tickets.