Make WordPress Core

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#57666 closed defect (bug) (fixed)

Help tab on User list screen is missing help tab row action info

Reported by: kebbet's profile kebbet Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch has-screenshots commit
Focuses: administration, ui-copy Cc:

Description

On the screen Users, the help tab is missing info about the row action View.

The row actions typically avalible are:
Edit | Delete | View | Send password reset

But the help tab only lists

- Edit
- Remove/Delete
- Send password reset

Attachments (1)

users-help-tab.png (177.2 KB) - added by kebbet 16 months ago.
Above: the help tab missing info on View. Below: row actions with all avalible actions.

Download all attachments as: .zip

Change History (12)

@kebbet
16 months ago

Above: the help tab missing info on View. Below: row actions with all avalible actions.

This ticket was mentioned in PR #4033 on WordPress/wordpress-develop by @kebbet.


16 months ago
#1

  • Keywords has-patch added; needs-patch removed

@kebbet commented on PR #4033:


16 months ago
#2

The check for current user ID is not correct. Maybe just leave the check out and always display the help tab info. Or is there a filter that sets author archives to false globally?

@kebbet commented on PR #4033:


16 months ago
#3

After patch:
https://i0.wp.com/user-images.githubusercontent.com/11491369/217456774-60a78728-3735-4946-8684-a47973f416c2.png

#4 @kebbet
16 months ago

  • Keywords has-screenshots needs-copy-review added

#5 @audrasjb
16 months ago

Hello @kebbet, thanks for the ticket and patch!

This changeset looks pretty good to me.
I think this bugfix can be moved to milestone 6.2 if we have a rapid review of the copy changes.

Pinging @marybaum, @webcommsat and/or @oglekler as Help/About component maintainers: is it possible to get a review of the above copy changes so this could ship in WP 6.2? Thanks!

#6 @kebbet
16 months ago

Thanks for considering. For the ease of reviewing, the string is:

<strong>View</strong> takes you to a public author archive which lists all the posts published by the user.

#7 @SergeyBiryukov
16 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.2

Thanks for the ticket! The PR looks good to me.

#8 @webcommsat
16 months ago

  • Keywords needs-copy-review removed

Thanks for the ping. Copy review completed. Thanks @kebbet . This is good to go. Thanks @SergeyBiryukov and @audrasjb.

#9 @audrasjb
16 months ago

  • Owner set to audrasjb
  • Status changed from new to accepted

Great, thanks.
Self assigning for commit.

#10 @audrasjb
16 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55297:

Help/About: Add info about the "View" row action link to the Users screen help tab.

Props kebbet, audrasjb, SergeyBiryukov, webcommsat.
Fixes #57666.

Note: See TracTickets for help on using tickets.