Make WordPress Core

Opened 4 months ago

Last modified 3 days ago

#57675 reviewing enhancement

Placeholder for tagline is confusing

Reported by: cybr's profile Cybr Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.1
Component: Administration Keywords: has-patch has-screenshots
Focuses: accessibility Cc:


Previous: #6479 (Encourage people to change default tagline).

The default tagline got emptied. To maintain the iconic phrase "Just another WordPress site," it was put as a placeholder for the field.

Placeholders are generally bad for accessibility because many users cannot discern whether it's actual input or the real value. See

The highlights:

  1. Placeholder text that disappears when the cursor is placed in a form field is irritating for users navigating with the keyboard.
  2. Fields with stuff in them are less noticeable.
  3. Users may mistake a placeholder for data that was automatically filled in.
  4. Occasionally users have to delete placeholder text manually.

By putting e.g., in front of the placeholder, this may be somewhat alleviated. Perhaps it might be best to let go of the iconic phrase altogether until a proper admin interface is found where we may reintroduce it.

Attachments (6)

57675.patch (1.1 KB) - added by sabernhardt 4 months ago.
tagline-example-in-description.png (6.6 KB) - added by sabernhardt 4 months ago.
57675.1.patch (1.7 KB) - added by sabernhardt 4 months ago.
57675.2.patch (1.3 KB) - added by sabernhardt 4 weeks ago.
adding example to field description, without inline-block styling
Capture d’écran 2023-05-03 à 07.14.00.png (54.4 KB) - added by audrasjb 4 weeks ago.
57675.2.patch looks good, except we'd probably need a final dot in this paragraph?
Capture d’écran 2023-05-03 à 07.20.12.png (109.2 KB) - added by audrasjb 4 weeks ago.
Patch tested on multisite as well

Download all attachments as: .zip

Change History (19)

This ticket was mentioned in Slack in #core by cybr. View the logs.

4 months ago

#2 @audrasjb
4 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 6.3

Hello and thanks for the ticket!

In my opinion, putting e.g., in front of the placeholder looks like the best option for now.

#3 @audrasjb
4 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#4 @sabernhardt
4 months ago

  • Focuses accessibility added

Thanks for the ticket!

The tagline's placeholder does not replace a label, and its information is nonessential to complete the form. I do not think disappearing text is a problem for this field, but confusion about whether the example is the input's predefined value still could be a concern. The example tagline may fit better within the description paragraph.

4 months ago

#5 @sabernhardt
4 months ago

  • Keywords has-patch added; needs-patch removed

#6 @Cybr
4 months ago

I think @sabernhardt's patch deals perfectly with all the concerns described.

Though the added text relies on vertical and code-indented spacing to add a space between the two lines, doing that bit me at least once during refactorization.

Opening and closing PHP tags isn't great for performance, either. But this is nitpicking.

#7 @sabernhardt
4 months ago

Nitpicking is good. I missed the __() translation function, too.

Also, I would like to consider keeping the example on one line with a reusable class for display: inline-block (I have wanted the class for something else before).

4 weeks ago

adding example to field description, without inline-block styling

#8 @sabernhardt
4 weeks ago

I removed the new inline-block class from the patch. Searching for an 'inline-block' class included a plugin that adds vertical-align: middle, and others may have inappropriate properties for this description. Besides, it was not clearly better with that span.

4 weeks ago

57675.2.patch looks good, except we'd probably need a final dot in this paragraph?

#9 @audrasjb
4 weeks ago

  • Keywords has-screenshots added

57675.2.patch looks good to me. Should we have a final dot in English, though?

4 weeks ago

Patch tested on multisite as well

#10 @sabernhardt
4 weeks ago

The period should be unnecessary with the "Example: [tagline]" structure, though it could easily be appropriate in translations. In U.S. English, the period would go inside the quotes, which I do not like here.

#11 @audrasjb
4 weeks ago

Ok then we have to add a period inside the quote of the existing string, right?

#12 @Cybr
4 weeks ago

The clearest notion about whether the period should be in or outside is this (source):

The final period or comma goes inside the quotation marks, even if it is not a part of the quoted material, unless the quotation is followed by a citation.

Since we aren't dealing with a citation, and since the default WordPress language is en_US, the period should be inside the quote marks.

I'm not a fan of this either when dealing with example strings that don't have punctuation intended — for the user could infer they should also use punctuation —, but I think we should follow the books. I couldn't find a single source claiming exceptions for American English.

We could somewhat workaround the inference by writing "Just another WordPress site," for example., but even then we have punctuation.

#13 @pavanpatil1
3 days ago

Test report -

WordPress: v6.2.2
Browser: Chrome
Os - Win10


The patch is looking good!

Note: See TracTickets for help on using tickets.