#57680 closed enhancement (fixed)
comment return description not define
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Upgrade/Install | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
1)
file_path
wp-admin\includes\class-theme-installer-skin.php
function name: hide_process_failed
line number: 69
file_path
wp-admin\includes\class-wp-automatic-updater.php
function name: is_disabled
line number: 31
Attachments (2)
Change History (9)
#1
@
2 years ago
@patelmohip Thanks for the ticket and patch.
<?php @return true|array True if automatic_updater is disable and wp_installing() available. Array with the test results.
If I look at the code, this is incorrect. The return value should always be a boolean. true
for the first two code paths, true|false
for the last.
And yes, while a filter can return anything, the filter is documented to filter a bool
value, so should return a bool
.
#2
@
2 years ago
Please take a look at my patch @patelmohip and @jrf. I think this looks better now.
Note: See
TracTickets for help on using
tickets.
patch added