Improve a comment in Services_JSON::utf162utf8()

[patelmohip]

file path

src\wp-includes\class-json.php

function: utf162utf8

line number: 198

[haritpanchal]

Same file, same comment, line 246

[audrasjb]

Hello and thanks for the ticket.

For reference, this comes from #21568.
Also, Services_JSON is an upstream lib:
​https://github.com/pear/Services_JSON/blob/trunk/JSON.php#L171

Not sure it is relevant to change this.

[jrf]

It's an external library, on top of which the use of this library within WP is also deprecated (since WP 5.3)....

[SergeyBiryukov]

Replying to audrasjb:

For reference, this comes from #21568.

Seems even earlier than that :) [23376] / #21568 updated the library version to 1.0.3, but this comment has been around since the library was introduced in [11875] / #10337.

Also, Services_JSON is an upstream lib

That was my initial thought too, but I see some changes over the years, including typo fixes and other documentation edits, so we might as well improve this comment :)

[jrf]

Replying to SergeyBiryukov:

Also, Services_JSON is an upstream lib

That was my initial thought too, but I see some changes over the years, including typo fixes and other documentation edits, so we might as well improve this comment :)

As the class is deprecated and the JSON extension a required extension by WP, I'd much rather we - at some point in the near future - remove it entirely.

[SergeyBiryukov]

Replying to jrf:

As the class is deprecated and the JSON extension a required extension by WP, I'd much rather we - at some point in the near future - remove it entirely.

Fair enough :)

[SergeyBiryukov]

Closing per the discussion above, it looks like the consensus is not to make any further documentation fixes in this file.