Make WordPress Core

#57681 closed defect (bug) (wontfix)

Improve a comment in Services_JSON::utf162utf8()

Reported by: patelmohip's profile patelmohip Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch close
Focuses: docs, coding-standards Cc:

Description

file path

src\wp-includes\class-json.php

function: utf162utf8

line number: 198

Attachments (1)

57681.patch (1.1 KB) - added by patelmohip 13 months ago.

Download all attachments as: .zip

Change History (8)

@patelmohip
13 months ago

#1 @haritpanchal
13 months ago

Same file, same comment, line 246

#2 follow-up: @audrasjb
13 months ago

  • Keywords 2nd-opinion added

Hello and thanks for the ticket.

For reference, this comes from #21568.
Also, Services_JSON is an upstream lib:
https://github.com/pear/Services_JSON/blob/trunk/JSON.php#L171

Not sure it is relevant to change this.

Last edited 13 months ago by SergeyBiryukov (previous) (diff)

#3 @jrf
13 months ago

  • Keywords close added; 2nd-opinion removed

It's an external library, on top of which the use of this library within WP is also deprecated (since WP 5.3)....

#4 in reply to: ↑ 2 ; follow-up: @SergeyBiryukov
13 months ago

Replying to audrasjb:

For reference, this comes from #21568.

Seems even earlier than that :) [23376] / #21568 updated the library version to 1.0.3, but this comment has been around since the library was introduced in [11875] / #10337.

Also, Services_JSON is an upstream lib

That was my initial thought too, but I see some changes over the years, including typo fixes and other documentation edits, so we might as well improve this comment :)

#5 in reply to: ↑ 4 ; follow-up: @jrf
13 months ago

Replying to SergeyBiryukov:

Also, Services_JSON is an upstream lib

That was my initial thought too, but I see some changes over the years, including typo fixes and other documentation edits, so we might as well improve this comment :)

As the class is deprecated and the JSON extension a required extension by WP, I'd much rather we - at some point in the near future - remove it entirely.

#6 in reply to: ↑ 5 @SergeyBiryukov
13 months ago

Replying to jrf:

As the class is deprecated and the JSON extension a required extension by WP, I'd much rather we - at some point in the near future - remove it entirely.

Fair enough :)

#7 @SergeyBiryukov
10 months ago

  • Component changed from Comments to General
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Summary changed from wrong function comment to Improve a comment in Services_JSON::utf162utf8()

Closing per the discussion above, it looks like the consensus is not to make any further documentation fixes in this file.

Note: See TracTickets for help on using tickets.