Changes between Version 1 and Version 2 of Ticket #57683, comment 12
- Timestamp:
- 03/07/2023 03:45:15 PM (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #57683, comment 12
v1 v2 1 1 Yeah, that was my initial suggestion above - to drop mysql2date it from here. :) 2 2 3 The PR looks tad wrong though, because without specifying time zone you would try to parse local time as UTC (or who knows what if end user messes with it, we are trying to proof against that in the long run). remember - the database field doesn't contain any time zone information, so it can't be parsed out of it.3 The PR looks tad wrong though, because without specifying time zone you would try to parse local time as UTC (or who knows what if end user messes with it, we are trying to proof against that in the long run). Remember - the database field doesn't contain any time zone information, so it can't be parsed out of it. 4 4 5 5 With some more thinking I am now pondering that we probably need a proper mysql2date replacement. Otherwise everywhere this (parsing post time from database) needs to be done there will be potential for diverging implementations and slip ups.