Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #57683, comment 14


Ignore:
Timestamp:
03/07/2023 07:19:31 PM (3 years ago)
Author:
Rarst
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #57683, comment 14

    initial v1  
    11Does it matter in this code verbatim? Maybe not.
    22
    3 Does it matter that it introduces ambiguity about what time zone the operation happens in? Yes. Because that's why this component is so broken - it was all coded on that principle.
     3Does it matter that it introduces ambiguity about what time zone the operation happens in? Yes. Because that's why this component is so broken - it was all coded on the principle of situationally convenient, conceptually wrong.
    44
    55If the performance preference here is to process this sans time zone, I would rather suggest to tear the input apart into strings (and document why it's done that way). Instantiating a DateTime object into knowingly invalid state is bad.