Context Navigation

← Previous Ticket
Next Ticket →

#57691 closed defect (bug) (fixed)

Short array syntax used in WP_HTML_Tag_Processor docs/examples

Reported by:	aristath	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	6.2
Component:	HTML API	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	docs

Description

Docs for methods in the WP_HTML_Tag_Processor object use a short array syntax. However, that syntax is not allowed in WP.

Change History (6)

This ticket was mentioned in PR #4048 on WordPress/wordpress-develop by @aristath.

3 years ago #1

Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/57691

@aristath commented on PR #4048:

3 years ago #2

This is a backport of https://github.com/WordPress/gutenberg/pull/47958

#3 @aristath
3 years ago

Done in Gutenberg in https://github.com/WordPress/gutenberg/pull/47958. The PR attached above is a backport.

#4 @SergeyBiryukov
3 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 55304:

Docs: Replace short array syntax in WP_HTML_Tag_Processor documentation.

Per WordPress PHP Coding Standards:

Using long array syntax ( array( 1, 2, 3 ) ) for declaring arrays is generally more readable than short array syntax ( [ 1, 2, 3 ] ), particularly for those with vision difficulties. Additionally, it’s much more descriptive for beginners.

Arrays must be declared using long array syntax.

Original PR from Gutenberg repository:

#47958 Docs: Don't recommend using short array syntax in WP_HTML_Tag_Processor

Follow-up to [55203], [55206].

Props aristath, poena.
Fixes #57691.

@SergeyBiryukov commented on PR #4048:

3 years ago #5

Thanks for the PR! Merged in r55304.

#6 @SergeyBiryukov
3 years ago

Component General → HTML API

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#57691 closed defect (bug) (fixed)

Short array syntax used in WP_HTML_Tag_Processor docs/examples

Description

Change History (6)

This ticket was mentioned in ​PR #4048 on ​WordPress/wordpress-develop by ​@aristath. 3 years ago #1

​@aristath commented on ​PR #4048: 3 years ago #2

#3 @aristath 3 years ago

#4 @SergeyBiryukov 3 years ago

​@SergeyBiryukov commented on ​PR #4048: 3 years ago #5

#6 @SergeyBiryukov 3 years ago