Make WordPress Core

#57697 closed defect (bug) (reported-upstream)

Wrong property name on style-engine.js

Reported by: papazetis's profile papazetis Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: Cc:

Description

const lineHeight = {
  name: 'letterSpacing',
  generate: (style, options) => {
    return generateRule(style, options, ['typography', 'lineHeight'], 'lineHeight');
  }
};

/wp-includes/js/dist/style-engine.js on line 419 the name property is wrong

Attachments (1)

package.png (866.8 KB) - added by codemonksuvro 14 months ago.

Download all attachments as: .zip

Change History (6)

#1 @codemonksuvro
14 months ago

Where can I make the changes to it? I have checked it, and this is a package for WordPress called style-engine. so where i will have to change this correction? No changes has shown in the source tree for it. please show the screenshot from here. https://core.trac.wordpress.org/attachment/ticket/57697/package.png

#2 @costdev
14 months ago

  • Component changed from General to Editor

Hi @papazetis and @codemonksuvro, thanks for opening this ticket and looking into this!

The file to be patched is here on the Gutenberg GitHub repository.

Please search for an existing issue, and if one doesn't exist, open a new issue and drop the link in here so we can close this ticket as reported-upstream. Thanks! 🙂

#3 @codemonksuvro
14 months ago

Here is the issue link that I have created, https://github.com/WordPress/gutenberg/issues/48090
and here is the pull request that I have made for the fix: https://github.com/WordPress/gutenberg/pull/48091

@costdev please inform me if any further action requires to solve this issue.

#4 @tanjimtc71
14 months ago

Hi @codemonksuvro !

Just wanted to drop you a quick message to let you know that the issue you created on GitHub looks good. Your contribution is highly appreciated. Thank you!

#5 @costdev
14 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

Thanks for creating the issue and pull request @codemonksuvro! Also be sure to edit the PR description and add Fixes #48090 so that it links the pull request to the issue 🙂

I'll close this ticket as reported-upstream now that it will be handled in the Gutenberg repository.

Note: See TracTickets for help on using tickets.