Context Navigation

← Previous Ticket
Next Ticket →

#57701 closed defect (bug) (fixed)

Do not prime term meta in `wp_get_object_terms`

Reported by:	spacedmonkey	Owned by:	spacedmonkey
Priority:	normal	Milestone:	6.3
Component:	Taxonomy	Version:	6.2
Severity:	normal	Keywords:	good-first-bug has-patch
Cc:		Focuses:	performance

Description

Discoveried while working on [55252].

In [38667] in wp_get_object_terms use get_terms / WP_Term_Query. By default, this also prime term meta. But in most case, term meta will not be needed. It should not be primed by default.

See screenshot for example.

Attachments (1)

Screenshot 2023-02-13 at 00.12.05.png (118.0 KB ) - added by spacedmonkey 3 years ago.

Download all attachments as: .zip

Change History (10)

@spacedmonkey
3 years ago

Attachment Screenshot 2023-02-13 at 00.12.05.png added

#1 @spacedmonkey
3 years ago

Related: #57645

#2 @spacedmonkey
3 years ago

Keywords needs-patch good-first-bug added

#3 @spacedmonkey
3 years ago

Milestone Awaiting Review → 6.3

This ticket was mentioned in PR #4263 on WordPress/wordpress-develop by rutviksavsani.

3 years ago #4

Keywords has-patch added; needs-patch removed

Trac ticket:

#5 @spacedmonkey
3 years ago

@rutviksavsani Can you look at your PR again. After a rebase it seems have unit tests failing.

#6 @rutviksavsani
3 years ago

@spacedmonkey Thanks for pointing that out, I did fix the tests. It can be taken a look at now.

#7 @spacedmonkey
3 years ago

Owner set to spacedmonkey
Resolution → fixed
Status new → closed

In 55759:

Taxonomy: Do not prime term meta in wp_get_object_terms.

Passing update_term_meta_cache argument value false by default resulting in get_terms to not prime the term meta cache in wp_get_object_terms. Priming of term meta is not needed in this context.

Props spacedmonkey, rutviksavsani.
Fixes #57701.

@spacedmonkey commented on PR #4263:

3 years ago #8

Committed in https://core.trac.wordpress.org/changeset/55759

#9 @spacedmonkey
3 years ago

Dev note: https://make.wordpress.org/core/2023/07/13/improvements-to-the-metadata-api-in-wordpress-6-3/

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#57701 closed defect (bug) (fixed)

Do not prime term meta in `wp_get_object_terms`

Description

Attachments (1)

Change History (10)

@spacedmonkey 3 years ago

#1 @spacedmonkey 3 years ago

#2 @spacedmonkey 3 years ago

#3 @spacedmonkey 3 years ago

This ticket was mentioned in ​PR #4263 on ​WordPress/wordpress-develop by ​rutviksavsani. 3 years ago #4

#5 @spacedmonkey 3 years ago

#6 @rutviksavsani 3 years ago

#7 @spacedmonkey 3 years ago

​@spacedmonkey commented on ​PR #4263: 3 years ago #8

#9 @spacedmonkey 3 years ago