Remove server-side redirection in site editor

[ntsekouras]

Remove server-side redirection if missing postType and postId query args when visiting Site Editor.

This is not needed any more as the routing is handled client side.

Related GB PRs:

• ​https://github.com/WordPress/gutenberg/pull/48023
• ​https://github.com/WordPress/gutenberg/pull/47777

Testing instructions would be to click Appearance->Editor in WP admin and everything should work as before.

It requires this PR to land first: ​https://github.com/WordPress/wordpress-develop/pull/4070

[ntsekouras]

#57715 was marked as a duplicate.

Trac ticket: https://core.trac.wordpress.org/ticket/57716

Remove server-side redirection if missing postType and postId query args when visiting Site Editor.
This is not needed any more as the routing is handled client side.
Related GB PRs:

• ​https://github.com/WordPress/gutenberg/pull/48023
• ​https://github.com/WordPress/gutenberg/pull/47777

Testing instructions would be to click Appearance->Editor in WP admin and everything should work as before.
It requires this PR to land first: ​https://github.com/WordPress/wordpress-develop/pull/4070

[hellofromTonya]

Currently reviewing for Beta 2 commit.

​https://github.com/WordPress/wordpress-develop/pull/4070 has been committed, unblocking this PR ✅

Currently reviewing for committing.

[hellofromTonya]

Patch: ​https://github.com/WordPress/wordpress-develop/pull/4070

• Confirmed covers the changes from ​https://github.com/WordPress/gutenberg/pull/48023/ ✅
• Tested before and after > works as expected ✅

Ready for commit 👍

Prepping commit now for Beta 2.

[hellofromTonya]

In 55338:

Editor: Remove missing postType and postId query args Site Editor redirect.

Removes the server-side redirection if missing postType and postId query args when visiting Site Editor. Why? This redirect is no longer needed as the routing is now handled client side (via [55333]).

References:

• ​Gutenberg PR 48023
• ​Gutenberg PR 47777

Follow-up to [55333], [53413], [53093].

Props ntsekouras, youknowriad.
Fixes #57716.

Committed via https://core.trac.wordpress.org/changeset/55338.

[johnbillion]

@hellofromTonya @ntsekouras Can and should the _resolve_home_block_template() function be removed or deprecated? It's no longer used since [55338].

[hellofromTonya]

Replying to johnbillion:

@hellofromTonya @ntsekouras Can and should the _resolve_home_block_template() function be removed or deprecated? It's no longer used since [55338].

Good catch @johnbillion! The code in this ticket was added in [53093] including _resolve_home_block_template().

Can it be removed or deprecated?
Yes, I think so.

• No longer used in Core or Gutenberg.
• No instances in wordpress.org's ​plugin directory.
• No instances in wordpress.org's ​theme directory.
• It's marked private (internal Core usage).

Here's its doc page ​https://developer.wordpress.org/reference/functions/_resolve_home_block_template/.

Deprecate or remove?
I'd like to remove it as it's not used (see above), likely low BC risk given its specific use case, and not wired as a callback. But "likely low BC risk" concerns me. Leaning towards deprecating.

What do you think @johnbillion?

[johnbillion]

Yeah +1 to deprecating and adding a note to the description to say the function is no longer used.

Deprecate _resolve_home_block_template() which is no longer used in Core since 55338.

As there is no replacement function, none is suggested in the deprecation notice.

Trac ticket: https://core.trac.wordpress.org/ticket/57716

[hellofromTonya]

@johnbillion if you have time, can you do a confidence check on ​PR 4143?

[hellofromTonya]

Thank you @johnbillion. Prepping commit now.

[hellofromTonya]

In 55436:

Editor: Deprecate _resolve_home_block_template().

The internal Core-only _resolve_home_block_template() function was introduced in [53093] for a specific purpose of resolving the template for a site's home page. It was used as part of the Site Editor's redirect when the postType and postId query args were missing. The server-side handling was removed in [55338]. The function is no longer used in Core.

This changeset deprecates the function and removes its tests.

Follow-up to [55338], [53093].

Props johnbillion, hellofromTonya.
Fixes #57716.

Committed via https://core.trac.wordpress.org/changeset/55436.