Loading property cannot be disabled in wp_get_attachment_image

[AlexHolsgrove]

In function wp_get_attachment_image() the docs suggest you can pass boolean “false” as part of the $attr for "loading" so that the attribute is omitted.

An example is also given in this article: ​https://make.wordpress.org/core/2020/07/14/lazy-loading-images-in-5-5/

<?php
echo wp_get_attachment_image(
    42,
    'large',
    false,
    array( 'loading' => false ),
);

However the property is still added (as loading="lazy"), caused by wp-includes/media.php function wp_filter_content_tags().

[costdev]

Reproduction Report

This report validates that the issue can be reproduced.

Steps to Reproduce or Test

1. Navigate to Media > Add New and upload an image.
2. Create a new file: wp-content/plugins/test_wp_get_attachment_image.php with the following contents:

   <?php
   
   /**
    * Plugin Name: Test <code>wp_get_attachment_image()</code>
    * Description: Tests <code>wp_get_attachment_image()</code>.
    * Author:      WordPress Core Contributors
    * Author URI:  https://make.wordpress.org/core
    * License:     GPLv2 or later
    * Version:     1.0.0
    */
   
   add_action(
           'admin_notices',
           function() {
                   $attachment = get_posts(
                           array(
                                   'orderby'        => 'rand',
                                   'numberposts'    => 1,
                                   'post_type'      => 'attachment',
                                   'post_mime_type' => 'image',
                                   'post_status'    => 'inherit',
                           )
                   );
   
                   $image = wp_get_attachment_image(
                           $attachment[0]->ID,
                           'large',
                           false,
                           array( 'loading' => false ),
                   );
   
                   printf(
                           '<div class="notice notice-info">%s</div>',
                           esc_html( $image )
                   );
           }
   );
   

3. Navigate to Plugins > Installed plugins and activate "Test wp_get_attachment_image()".
4. Check the output in the admin notice.

Expected Results

• 🐞 The loading="lazy" attribute is still added.

Environment

• Server: Apache (Linux)
• WordPress: 6.2-beta2-55340-src and WordPress 6.1.1
• Browser: Chrome 109.0.0.0
• OS: Windows 10
• Theme: Twenty Twenty-Two
• Plugins:
  • Test wp_get_attachment_image() 1.0.0

Actual Results

• ❌ Could not reproduce on WordPress 6.2-beta2-55340-src or WordPress 6.1.1.

Notes

• @AlexHolsgrove Is there any information missing from your report, or my steps above, to reproduce this issue?

[AlexHolsgrove]

Thanks @costdev - your test shows the function working correctly. I also moved this to my front-end template and also worked correctly.

I can repeat my issue, however if I place the code inside a Gutenberg block template, using Advanced Custom Fields, so I believe the issue is with their plugin calling one of the filters.

Happy to close this as a non-issue.

[SergeyBiryukov]

Thanks for the follow-up!