WordPress.org

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#5774 closed defect (bug) (fixed)

Write:Post>Save shouldn't "Saved on: 1999-11-30 at 00:00"

Reported by: lloydbudd Owned by: ryan
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords: has-patch
Focuses: Cc:

Description

Write:Post>Save shouldn't "Saved on: 1999-11-30 at 00:00"

ENV: WP trunk r6735 (2.4-bleeding)

Clicking Save when authoring a new post results in the phrase "Saved on: 1999-11-30 at 00:00" above the Save and Publish buttons. The time shown should be the time the post was saved.

Attachments (3)

r6735_date.diff (1.2 KB) - added by ffemtcj 14 years ago.
Fixes problem of saved on
5774.diff (1.4 KB) - added by DD32 14 years ago.
Uses post_modified if post_date is 0000..
5774.2.diff (1.9 KB) - added by DD32 14 years ago.

Download all attachments as: .zip

Change History (12)

#1 follow-up: @ryan
14 years ago

For drafts we should use post_modified rather than post_date for the saved on date.

@ffemtcj
14 years ago

Fixes problem of saved on

#2 in reply to: ↑ 1 @ffemtcj
14 years ago

  • Cc ffemtcj added
  • Keywords has-patch added

Replying to ryan:

For drafts we should use post_modified rather than post_date for the saved on date.

Here is a patch that fixes the problem with saving posts and pages. My only concern is that when you save a post (or page), above the save button in the light blue area it says Saved on: <date> then below the save button in the grey area it says last edited on <date>.. Because they are both date_modified, they both show up the same. Isn't this a little redundant?

#3 @ryan
14 years ago

  • Owner changed from anonymous to ryan

@DD32
14 years ago

Uses post_modified if post_date is 0000..

#4 @markjaquith
14 years ago

Yeah, I don't get the point of "Saved on" -- that'll be the same as "last modified" except for published posts "which show "published on." Why not just axe the "Saved on" text?

#5 @ryan
14 years ago

The design mockups have it saying "Saved by Joe User on xxx", but we don't store the last user who modified the post anywhere. It's meant to let people know if someone else is editing the post and when they did it. Perhaps we could save the ID of the last person to edit in postmeta.

@DD32
14 years ago

#6 @DD32
14 years ago

2nd patch added to fix Future posts.

Future posts set post_date to a future date, while still being a draft, So WordPress cannot make its decisions based on a null time, only the status of the post. See #5755 which is another symptom of this display issue i believe.

Re: Saved on

I personally feel "Last Modified" should be shown in the exact same place as "Published on" on the next line IF the modified time is different from the post time. They're equal data, and theres no reason why the last modified should be hidden below it.

I also think the Autosave should be modified to update the same fields/locations, but i think that might be coming in more of the redesign anyway.

#7 @ryan
14 years ago

I don't think anyone is working on updating the fields with autosave, but that's something I've been wanting. Showing the Preview button after autosaving a new post might be nice too. Hopefully the button popping out of nowhere wouldn't be too visually jarring.

#8 @ryan
14 years ago

(In [6768]) Fix display of dates for drafts and future posts. Props DD32 and ffemtcj. see #5774

#9 @ffemtcj
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.