WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Last modified 5 months ago

#57741 new defect (bug)

Core throwing 'Attempt to read property "post_type" on null'

Reported by: haykuro's profile haykuro Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Media Keywords: reporter-feedback
Focuses: Cc:

Description

A calls B. B calls C.

C is calling get_post() passing in args from B.

C then proceeds to immediately use the results of get_post() ($post->post_type) without checking the response, resulting in an edge condition where a warning is thrown: Attempt to read property "post_type" on null

A: ​https://github.com/WordPress/WordPress/blob/f0789b64238a97adc3ce0c9b8cdf33c1753f550c/wp-admin/post.php#L186-L189

B: ​https://github.com/WordPress/WordPress/blob/f0789b64238a97adc3ce0c9b8cdf33c1753f550c/wp-admin/edit-form-blocks.php#L249-L253

C: ​https://github.com/WordPress/WordPress/blob/f0789b64238a97adc3ce0c9b8cdf33c1753f550c/wp-includes/media.php#L4552-L4558

Change History (2)

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Posts, Post Types

#2 @SirLouen
5 months ago

  • Component changed from Posts, Post Types to Media
  • Keywords reporter-feedback added
  • Version 6.1.1 deleted

@haykuro yes, looking at the logic, this can definitely happen.
I have not dug too much into possibilities because I'm currently triaging tickets, but I wonder if this can be happening on a healthy WP or if this is caused by a faulty code brought by a plugin or something like that.
But can you explain the exact conditions for this to happen, ideally step by step
If you can reproduce this in ​WordPress Playground it would be better.

Note: See TracTickets for help on using tickets.