Pluggable get_avatar()

[ryan]

So that themes can rely on an avatar function always being available, let's introduce a get_avatar() pluggable function. By default it can use gravatar (disclaimer, my company owns gravatar), but plugins can replace the function altogether or hook onto a filter to use a different service. We might need new options to select avatar rating and allow avatars to not be displayed at all.

[ryan]

Sample implementation. Not yet tested.

[DD32]

apologies for the off-topic: With Gravatar, would it be possible in the future to allow setting it for a domain? I use contact+<sitename>@host for most commenting/signing up to blogs.. So its utterly useless to me at present :P

As to this ticket, It sounds like a good idea for themes, but, i feel by default it might be best not to have the gravatar stuff in there, I'd like it to be linked to my wordpress.com username instead somehow, if that means i have to add a plugin to enable wordpress.com integration, or add a plugin to enable gravaar integration then thats fine by me, so maybe WordPress should just have a stub in place?

(But In other words, I'd rather it linked to wordpress.com than gravatar.com)

[ryan]

wordpress.com doesn't have any external avatar lookup. wordpress.com avatars might someday be served from gravatar anyway.

[DD32]

wordpress.com doesn't have any external avatar lookup. wordpress.com avatars might someday be served from gravatar anyway.

Ah ok.

[josephscott]

I haven't seen any way to set the avatar_rating option yet.

[ryan]

The UI isn't there yet. I'm thinking of "Show Avatars" <yes|no> and "Show Avatars Rated:" <g|pg|r|x> options in Options->Reading. I can rough in something and let the designers decide on layout and wording.

I updated the patch to return false if the 'show_avatars' option is not true. Themes would need to check for a false return and style accordingly.

[ryan]

(In [6748]) get_avatar(). see #5775

[Viper007Bond]

"Show Avatars Rated" should be more clear. I know what it means, but noobs may not. Either that, it needs some explanation text.

[ryan]

Agreed. I'm just roughing it in for now. Suggestions welcome.

[ryan]

(In [6749]) Gonna serve default avatars from gravatar. see #5775

[ryan]

Removed the default avatar images. We're going to serve those off of gravatar. The images aren't on gravatar yet so the gravatar branded default will show for now.

[Viper007Bond]

Save a couple CPU cycles

[ryan]

(In [6756]) Precompute the hash of the unknown avatar user to save an md5 call. Props Viper007Bond. see #5775

[JeremyVisser]

Shouldn't the "Don't show Avatars" / "Show Avatars" option box be a checkbox instead?

Or is there an intention to add more options to this box? If not, it should definitely become a checkbox.

[ryan]

A checkbox is fine. Anyone want to patch it up? Also, anyone have a suggestion for better text than "Show Avatars Rated"?

[ryan]

(In [6945]) Allow comment object to be passed to get_avatar() for convenience. see #5775

[ryan]

(In [6946]) Allow comment object to be passed to get_avatar() for convenience. see #5775

[spikeyslam]

$default is getting urlencoded to soon and prevents usage as an img src later in the function.

[spikeyslam]

urlencode($default) when needed

[ryan]

(In [7096]) urlencode only when needed. Props spikeyslam. see #5775

[djr]

Replying to ryan:

A checkbox is fine. Anyone want to patch it up? Also, anyone have a suggestion for better text than "Show Avatars Rated"?

Choose Avatar rating