Make WordPress Core

Opened 14 months ago

Last modified 14 months ago

#57761 new enhancement

Prevent non-Latin characters from being used in filenames

Reported by: danielbachhuber's profile danielbachhuber Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:


In r55294, I committed a few files with non-Latin characters in the filenames:

  • tests/phpunit/data/themedir1/block-theme-non-latin/parts/small-header-τεστ.html
  • tests/phpunit/data/themedir1/block-theme-non-latin/parts/small-header-测试.html
  • tests/phpunit/data/themedir1/block-theme-non-latin/templates/page-τεστ.html
  • tests/phpunit/data/themedir1/block-theme-non-latin/templates/page-测试.html

These filenames caused SVN checkouts to break in some environments (example):

svn: E000022: Can't convert string from 'UTF-8' to native encoding:
svn: E000022: /tmp/wp-cli-test-run--63ef7647f35894.16389676/wordpress-tests-lib/data/themedir1/block-theme-non-latin/parts/small-header-{U+03C4}{U+03B5}{U+03C3}{U+03C4}.html
cwd: /tmp/wp-cli-test-run--63ef7647f35894.16389676/
run time: 6.1638081073761

It'd probably be best to have a pre-commit hook to prevent non-Latin filenames from being committed in the future.

Change History (1)

#1 @danielbachhuber
14 months ago

In 55362:

REST API: Only use Latin characters in test filenames.

Non-Latin characters can break SVN checkout in some environments.

Follow up from [55294].

See #57329, #57761.

Note: See TracTickets for help on using tickets.