WordPress.org
Get WordPress

Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#57776 closed feature request (duplicate)

Twenty Fourteen: add_theme_support( "title-tag" ).

Reported by: dhrumilk's profile dhrumilk Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: template Cc:

Description

REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.

Attachments (3)

57776.diff​ (845 bytes) - added by dhrumilk 10 months ago.
Added theme support code.
before-patch.png​ (214.3 KB) - added by dhrumilk 10 months ago.
Before patch
after-patch.png​ (242.2 KB) - added by dhrumilk 10 months ago.
After patch

Download all attachments as: .zip

Change History (7)

@dhrumilk
10 months ago

Added theme support code.

#1 @dhrumilk
10 months ago

  • Keywords has-patch added

@dhrumilk
10 months ago

Before patch

@dhrumilk
10 months ago

After patch

#2 @sabernhardt
10 months ago

  • Component changed from Themes to Bundled Theme
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed
  • Version changed from trunk to 3.8

Hi and thanks for the report!

The hard-coded title tags were kept in header.php templates for backward compatibility in bundled themes from Twenty Ten to Twenty Fourteen.

See #34456 and #39661.

#3 @dhrumilk
10 months ago

@sabernhardt oh okay, did not know about that.
Sorry and thank you for the info :)

#4 @sabernhardt
10 months ago

I needed to search for the tickets myself :)

It does not look good when bundled themes cannot pass those tests, but changing the themes' titles probably would not be any safer today than it would have been seven years ago.

Last edited 10 months ago by sabernhardt (previous) (diff)
Note: See TracTickets for help on using tickets.