WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#57776 closed feature request (duplicate)

Twenty Fourteen: add_theme_support( "title-tag" ).

Reported by: dhrumilk Owned by:
Priority: normal Milestone:
Component: Bundled Theme Version: 3.8
Severity: minor Keywords: has-patch
Cc: Focuses: template

Description

REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.

Attachments (3)

57776.diff​ (845 bytes ) - added by dhrumilk 4 years ago.
Added theme support code.
before-patch.png​ (214.3 KB ) - added by dhrumilk 4 years ago.
Before patch
after-patch.png​ (242.2 KB ) - added by dhrumilk 4 years ago.
After patch

Download all attachments as: .zip

Change History (7)

@dhrumilk
4 years ago

Added theme support code.

#1 @dhrumilk
4 years ago

  • Keywords has-patch added

@dhrumilk
4 years ago

Before patch

@dhrumilk
4 years ago

After patch

#2 @sabernhardt
4 years ago

  • Component Themes → Bundled Theme
  • Milestone Awaiting Review
  • Resolution → duplicate
  • Status new → closed
  • Version trunk → 3.8

Hi and thanks for the report!

The hard-coded title tags were kept in header.php templates for backward compatibility in bundled themes from Twenty Ten to Twenty Fourteen.

See #34456 and #39661.

#3 @dhrumilk
4 years ago

@sabernhardt oh okay, did not know about that.
Sorry and thank you for the info :)

#4 @sabernhardt
4 years ago

I needed to search for it myself :)

It does not look good when bundled themes cannot pass those tests, but changing it probably would not be any safer today than it would have been seven years ago.

Version 0, edited 4 years ago by sabernhardt (next)
Note: See TracTickets for help on using tickets.