Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#57808 closed defect (bug) (fixed)

Correct duplicate hook reference for 'notify_moderator'

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Comments Keywords: good-first-bug has-patch
Focuses: docs Cc:

Description

Per the documentation standards, duplicate hook instances should be marked as such:

/** This filter is documented in path/to/filename.php */

The instance of the notify_moderator filter in wp_new_comment_notify_moderator() is marked with:

/** This filter is documented in wp-includes/comment.php */

However, the original filter location is wp_notify_moderator() in wp-includes/pluggable.php, so the reference in wp_new_comment_notify_moderator() should be corrected to:

/** This filter is documented in wp-includes/pluggable.php */

Follow-up to [35339], [35725].

Change History (4)

This ticket was mentioned in PR #4136 on WordPress/wordpress-develop by @zevilz.


2 years ago
#1

  • Keywords has-patch added; needs-patch removed

#2 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 6.2

#3 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 55424:

Docs: Correct duplicate hook reference for notify_moderator.

The original filter location is wp_notify_moderator() in wp-includes/pluggable.php.

This commit updates the instance in wp_new_comment_notify_moderator() to point to the correct file.

Follow-up to [35339], [35725].

Props zevilz.
Fixes #57808.

@SergeyBiryukov commented on PR #4136:


2 years ago
#4

Thanks for the PR! Merged in r55424.

Note: See TracTickets for help on using tickets.