class-wp-term-query.php no error checking

[coleatkinson1]

Attempt to read property "count" on null in /wp-includes/class-wp-term-query.php on line 768.
Does not check for failure of get_term function. Causes very annoying PHP warnings.

[kebbet]

I can not find any call to count on line 768 in that file in trunk or 6.1. What version of WordPress is this issue present?

[jakariaistauk]

Hello,
I also can not find any call to count on line 768 in that file in the trunk.

But I found some code about count on line 802. are you talking about that?

[sabernhardt]

The 768 line number is more than two years old, but the condition still checks $child->count on the current line 844.

$child = get_term( $child_id, $term->taxonomy );
if ( $child->count ) {
  continue 2;
}

[kebbet]

How did you generate the warning @coleatkinson1?

Is there a way to generate the PHP-warning so a potential fix can be verified?

[sabernhardt]

Related/duplicate: #63877

[SergeyBiryukov]

Hi there, welcome to WordPress Trac! Thanks for the ticket.

#63877 has some more details and discussion, let's continue there.