Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #57839, comment 74


Ignore:
Timestamp:
07/05/2023 11:25:15 AM (21 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #57839, comment 74

    initial v1  
    1616> Wondering if this change "can get away with" casting to strings before comparing. Seems int is also a valid key and/or value type there too.
    1717
    18 Seems reasonable, we already do that in a few other places, e.g. `__checked_selected_helper()`. But [56137] caused a few `Array to string conversion` warnings in `wp_filter_object_list()`, so restoring the loose comparison appears to be a safer option at this point.
     18Seems reasonable, we already do that in a few other places, e.g. `__checked_selected_helper()`. But [56137] caused a few `Array to string conversion` warnings in `wp_filter_object_list()` tests, so restoring the loose comparison appears to be a safer option at this point.
    1919
    2020Should be fixed in [56138] :)