Make WordPress Core

Opened 19 years ago

Closed 19 years ago

#5784 closed defect (bug) (fixed)

List of Users on wp-admin/users.php has its headers skipped

Reported by: Potter_System Owned by: markjaquith
Priority: lowest Milestone: 2.5
Component: General Version: 2.5
Severity: trivial Keywords: trivial wp-admin has-patch
Cc: Focuses:

Description

On wp-admin/users.php, the table used to list users had its headers skipped (in English, the ID header was over Username values, and so on)

Attachments (4)

users_table_skipped.patch​ (693 bytes ) - added by Potter_System 19 years ago.
Editing values of th tags on users.php
5784.diff​ (1.7 KB ) - added by markjaquith 19 years ago.
Another solution
5784.jpeg​ (26.5 KB ) - added by ffemtcj 19 years ago.
Image showing incorrect alignment
r6778_user_administration.diff​ (1.3 KB ) - added by ffemtcj 19 years ago.
Patch fixing alignment issue

Download all attachments as: .zip

Change History (10)

@Potter_System
19 years ago

Editing values of th tags on users.php

@markjaquith
19 years ago

Another solution

#1 @markjaquith
19 years ago

  • Owner changed from anonymous to markjaquith
  • Status new → assigned

I think it looks a little strange with the checkbox right next to the ID. It seems very different from similar interfaces I've seen where the checkboxes are clearly their own entity. See 5784.diff for a proposed solution.

#2 @markjaquith
19 years ago

I like the idea. The patch should use the "update" method to take advantage of automatic SQL escaping.

#3 @ffemtcj
19 years ago

See ​5779. The patch created in that ticket sets the formatting to the same as it is in the current version of WP. I don't see a need to change the formatting since there is nothing to gain from it. I suggest marking this as a duplicate.

#4 @ryan
19 years ago

  • Resolution → fixed
  • Status assigned → closed

(In [6776]) Fix users table formatting. Props Potter_System and markjaquith. fixes #5784

#5 @ffemtcj
19 years ago

  • Cc ffemtcj added
  • Resolution fixed
  • Status closed → reopened

#5784 does still does not correctly align the user list (see attached image). Also attached is a patch that will fix the alignment issue.

@ffemtcj
19 years ago

Image showing incorrect alignment

@ffemtcj
19 years ago

Patch fixing alignment issue

#6 @ffemtcj
19 years ago

  • Resolution → fixed
  • Status reopened → closed

Fixed r6852

Note: See TracTickets for help on using tickets.