Opened 22 months ago
Closed 17 months ago
#57855 closed defect (bug) (fixed)
Tests: Reduce usage of assertEquals for 6.3
Reported by: | hellofromTonya | Owned by: | |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | |
Focuses: | Cc: |
Description
Follow-up to:
The assertEquals()
test method does not check that the types of the expected and actual values match. This can hide subtle bugs especially when the values are falsey.
Tasks:
- Switch to using
assertSame()
when the type of the value in the assertion is important - Replace overall usage of
assertEquals()
with type-strict assertion methods, with the aim of potentially removing its usage altogether
To help ease the effort of backporting tests, changes should also be made upstream in the Gutenberg repository.
Change History (4)
Note: See
TracTickets for help on using
tickets.
In 56221: