#57856 (Update `caniuse` data for 6.3) – WordPress Trac

#1 @jrf
3 years ago

Description modified (diff)

#2 @desrosj
3 years ago

Resolution → fixed
Status new → closed

It looks like [56065] applied an update to the most recent database at that time.

When running grunt precommit:css, there are some changes to generated CSS files. I checked, and they're not present in the 6.2 branch. I backtracked and re-applied the update to the version of caniuse-lite that's being used after [56065], so something in that update is causing the changes even though there are no reported changes to targeted browsers in the update.

The changes are all removing instances of (-webkit-min-device-pixel-ratio: 1.25) within generated media queries. It's not something that will cause problems, so I think it's fine to just commit with the next version in #58869.

#3 @desrosj
3 years ago

In 56279:

General: Commit changes after running precommit:css.

The {min|max}-device-pixel-ratio syntax as a a non-standard CSS media feature that was used as an alternative to the now standard resolution. Prior to Safari 16.0, -webkit-{min|max}-device-pixel-ratio was needed to correctly support it.

This change is a result of the caniuse-lite update that was applied recently in [56065]. Though there were no changes to target browsers as a result of this update, it seems an upstream change identified these as unnecessary.

See #57856, #58869.
Props desrosj, joemcgill, isabel_brison.

#4 @davidbaumwald
3 years ago

Keywords dev-feedback added
Resolution fixed
Status closed → reopened

Reopening for backport to the 6.3 branch.

#5 @SergeyBiryukov
3 years ago

Keywords dev-reviewed added; dev-feedback removed

[56279] looks good to backport.

#6 @davidbaumwald
3 years ago

Owner set to davidbaumwald
Resolution → fixed
Status reopened → closed

In 56367:

General: Commit changes after running precommit:css.

The {min|max}-device-pixel-ratio syntax as a a non-standard CSS media feature that was used as an alternative to the now standard resolution. Prior to Safari 16.0, -webkit-{min|max}-device-pixel-ratio was needed to correctly support it.

This change is a result of the caniuse-lite update that was applied recently in [56065]. Though there were no changes to target browsers as a result of this update, it seems an upstream change identified these as unnecessary.

Props desrosj, joemcgill, isabel_brison, SergeyBiryukov, azaozz.
Reviewed by SergeyBiryukov, azaozz.
Backports [56279] to the 6.3 branch.
Fixes #57856.

Reported by:	desrosj	Owned by:	davidbaumwald
Priority:	normal	Milestone:	6.3
Component:	Build/Test Tools	Version:
Severity:	normal	Keywords:	dev-reviewed
Cc:		Focuses:

Make WordPress Core

Context Navigation

#57856 closed task (blessed) (fixed)

Update `caniuse` data for 6.3

Description (last modified by jrf)

Change History (6)

#1 @jrf
3 years ago

#2 @desrosj
3 years ago

#3 @desrosj
3 years ago

#4 @davidbaumwald
3 years ago

#5 @SergeyBiryukov
3 years ago

#6 @davidbaumwald
3 years ago

Download in other formats:

Make WordPress Core

Context Navigation

#57856 closed task (blessed) (fixed)

Update `caniuse` data for 6.3

Description (last modified by jrf)

Change History (6)

#1 @jrf 3 years ago

#2 @desrosj 3 years ago

#3 @desrosj 3 years ago

#4 @davidbaumwald 3 years ago

#5 @SergeyBiryukov 3 years ago

#6 @davidbaumwald 3 years ago

Download in other formats:

#1 @jrf
3 years ago

#2 @desrosj
3 years ago

#3 @desrosj
3 years ago

#4 @davidbaumwald
3 years ago

#5 @SergeyBiryukov
3 years ago

#6 @davidbaumwald
3 years ago