Make WordPress Core

Changes between Initial Version and Version 6 of Ticket #57873


Ignore:
Timestamp:
03/06/2023 06:47:51 PM (16 months ago)
Author:
jrf
Comment:

Replying to ayeshrajans:

Bleeding-edge PHPMailer :) Thank you.

#57874 has a way better description. I don't think I can edit the original description; I'm happy with however you suggest we proceed. We could copy-paste but perhaps someone with permissions update the ticket?

I have updated the description of this ticket now.

I took the liberty of deciding to not include the new DSN class because we initialize PHPMailer on our own, use no autoloader, and because we don't include the whole PHPMailer library anyway.

That makes perfect sense to me.

Also: the Hindi translation has been updated - do we need to ping the Polyglots team to get the translation used by WP updated as well ?

From what I see, we catch PHPMailer exceptions and throw a WP_Error with wp_mail_failed, containing the Exception message thrown by PHPMailer. However, we don't use PHPMailer's localization, so the Exception messages would be the same in v6.8.0 too. My guess is that we don't need to bother with the translations, because as far as WordPress is concerned, we don't change any of the source text strings. I don't understand Hindi to know if the updated translations are dramatically different, but pinging them could prove useful.

Want to send out a ping in Slack ? There must be a polyglots channel there, I suppose ?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #57873

    • Property Milestone changed from Awaiting Review to 6.3
  • Ticket #57873 – Description

    initial v6  
    1 PHPMailer v6.8.0 is released.
     1PHPMailer 6.8.0. has just been released. Mostly a bug fix release, though it also contains a new feature (DSN URL parsing).
    22
    3 Diff: https://github.com/PHPMailer/PHPMailer/compare/v6.7...v6.8.0
    4 Changelog: https://github.com/PHPMailer/PHPMailer/blob/master/changelog.md#version-680-march-6th-2023
     3Full details:
     4* https://github.com/PHPMailer/PHPMailer/releases/tag/v6.8.0
     5* https://github.com/PHPMailer/PHPMailer/compare/v6.7...v6.8.0
     6
     7@jrf has reviewed the diff and the changes look sensible to her, so she would recommend an update.
     8
     9**To be decided**: should the new `src/DSNConfigurator.php` file be included in WP or not ?
     10
     11Previously: #53430, #53953, #54514, #55187, #55277, #55976, #56016, #56413, #56772, #57281