WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#5789 closed defect (bug) (fixed)

feeds invalid / url not present -> prefer empty url instead of 'http://'

Reported by: neoxx Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.0
Component: General Keywords: has-patch tested commit reporter-feedback dev-feedback
Focuses: Cc:

Description

greetz!

we got a validation error (check ​http://www.feedvalidator.org/) in our feeds, because logged in commenters without an url in their profile automatically hold '​http://'. - possible solutions: leave the field Website ($profileuser->user_url) empty, if no url is present. remove 'emtpy' urls from feeds.

berny

Attachments (2)

5789.diff​ (788 bytes) - added by DD32 6 years ago.
5789.2.diff​ (1.4 KB) - added by Denis-de-Bernardy 5 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 DD32 — 6 years ago

  • Milestone changed from 2.6 to 2.0.12
  • Severity changed from major to normal

Looking at the Comments feed: ​http://dd32.id.au/comments/feed/ i cant see any evidance of the issue.

It appears that under current trunk the URL the commentor gives never makes it to the feed.

I assume this is a 2.0-branch only issue?

comment:2 DD32 — 6 years ago

  • Milestone changed from 2.0.12 to 2.6

It was just pointed out by FFEMTcJ on IRC that it might not've been in the feed i was looking at.

Indeed, If i look at the Atom feed i see the problem.

DD32 — 6 years ago

comment:3 DD32 — 6 years ago

  • Keywords has-patch added
  • Milestone changed from 2.6 to 2.5

comment:4 DD32 — 5 years ago

Any movement? or wontfix worthy?

Denis-de-Bernardy — 5 years ago

comment:5 Denis-de-Bernardy — 5 years ago

  • Keywords tested dev-feedback added; feed profile user removed

updated the patch, but even without it, I failed to reproduce any of this. might be useful for old installs, though.

comment:6 Denis-de-Bernardy — 5 years ago

  • Milestone changed from 2.9 to 2.8

comment:7 Denis-de-Bernardy — 5 years ago

  • Keywords commit reporter-feedback added

commit, invalid, wontfix?

comment:8 westi — 5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11249]) Filter out blank urls for commentors. Fixes #5789.

Note: See TracTickets for help on using tickets.