Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#57892 closed enhancement (fixed)

Editor: Update template description

Reported by: glendaviesnz's profile glendaviesnz Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.2 Priority: normal
Severity: normal Version: 6.2
Component: Editor Keywords: has-patch gutenberg-merge commit i18n-change
Focuses: ui-copy Cc:

Description (last modified by hellofromTonya)

Updates are needed to the Template Descriptions as these descriptions are made more prominent in 6.2.

References:

Attachments (1)

Test-Report-before-and-after.png (283.2 KB) - added by hellofromTonya 3 months ago.
Test Report: Before and after PR 4204 for the Index template.

Download all attachments as: .zip

Change History (19)

This ticket was mentioned in PR #4204 on WordPress/wordpress-develop by @glendaviesnz.


3 months ago
#1

  • Keywords has-patch added

#2 @andrewserong
3 months ago

  • Keywords gutenberg-merge added

#3 @peterwilsoncc
3 months ago

According to the schedule the soft string freeze (everything except the about page) went in to effect upon the release of beta 5.

How urgent are these changes?

@andrewserong commented on PR #4204:


3 months ago
#4

The PHP unit tests are failing. From a quick read, it looks like we might just need to update the following line with the new description: https://github.com/WordPress/wordpress-develop/blob/7b979b35150408289a2221ce06232a7491558307/tests/phpunit/tests/block-template-utils.php#L137

@glendaviesnz commented on PR #4204:


3 months ago
#5

The PHP unit tests are failing.

Thanks @andrewserong have updated the test.

#6 @glendaviesnz
3 months ago

How urgent are these changes?

We were told they could go in before the hard string freeze at RC1, but porting on behalf of someone else who is AKF due to travel. Have pinged design and pointed them to this ticket as they are the ones who can make a call on this.

#7 @Mamaduka
3 months ago

@peterwilsoncc, the design lead(s) requested and approved this change. It would be great if we could land this in WP 6.2.

#8 @sabernhardt
3 months ago

  • Focuses ui-copy added

#9 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 6.2

#10 @hellofromTonya
3 months ago

The reasonings are shared here https://github.com/WordPress/gutenberg/pull/48934#issuecomment-1461672012

I'd say it's fairly important. Reason being that template descriptions are given elevated prominence in the Site Editor now

Will discuss this during the pre-RC1 scrub happening in about 20 minutes in Make/Core slack.

This ticket was mentioned in Slack in #core by costdev. View the logs.


3 months ago

#13 @hellofromTonya
3 months ago

Discussed during today's pre-RC1 scrub:

There is consensus to commit these change as they improve the UX in the Site Editor and 6.2 makes these template descriptions more prominent.

Props @SergeyBiryukov @davidbaumwald for discussing.

#14 @hellofromTonya
3 months ago

  • Description modified (diff)
  • Keywords commit added
  • Summary changed from Port template description updates to 6.2 to Editor: Update template description

Patch: https://github.com/WordPress/wordpress-develop/pull/4204

Ready for commit 👍 Preparing it now

@hellofromTonya
3 months ago

Test Report: Before and after PR 4204 for the Index template.

#15 @hellofromTonya
3 months ago

  • Owner set to hellofromTonya
  • Resolution set to fixed
  • Status changed from new to closed

In 55500:

Editor: Add more details to template descriptions.

The template descriptions in get_default_block_template_types() are updated to add more details. Why? These descriptions are now more prominent in 6.2 to provide a better UX experience with more helpful information.

References:

Follow-up to [54761], [54104], [54269], [53129], [52331], [52062].

Props ntsekouras, andrewserong, bph, davidbaumwald, greenshady, glendaviesnz, hellofromTonya, jameskoster, mamaduka, peterwilsoncc, sabernhardt, SergeyBiryukov.
Fixes #57892.

#17 @hellofromTonya
3 months ago

  • Keywords i18n-change added

#18 @hellofromTonya
3 months ago

In 55501:

Editor: Combine Date template description translations.

Combine the 2 translatable strings into 1 string. Why? The example URL does not require a separate translation. Combining makes the string easier to view in context.

Follow-up to [55500].

Props SergeyBiryukov.
See #57892.

Note: See TracTickets for help on using tickets.