#57892 closed enhancement (fixed)
Editor: Update template description
Reported by: | glendaviesnz | Owned by: | hellofromTonya |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | 6.2 |
Component: | Editor | Keywords: | has-patch gutenberg-merge commit i18n-change |
Focuses: | ui-copy | Cc: |
Description (last modified by )
Updates are needed to the Template Descriptions as these descriptions are made more prominent in 6.2.
References:
Attachments (1)
Change History (19)
This ticket was mentioned in PR #4204 on WordPress/wordpress-develop by @glendaviesnz.
20 months ago
#1
- Keywords has-patch added
#3
@
20 months ago
According to the schedule the soft string freeze (everything except the about page) went in to effect upon the release of beta 5.
How urgent are these changes?
@andrewserong commented on PR #4204:
20 months ago
#4
The PHP unit tests are failing. From a quick read, it looks like we might just need to update the following line with the new description: https://github.com/WordPress/wordpress-develop/blob/7b979b35150408289a2221ce06232a7491558307/tests/phpunit/tests/block-template-utils.php#L137
@glendaviesnz commented on PR #4204:
20 months ago
#5
The PHP unit tests are failing.
Thanks @andrewserong have updated the test.
#6
@
20 months ago
How urgent are these changes?
We were told they could go in before the hard string freeze at RC1, but porting on behalf of someone else who is AKF due to travel. Have pinged design and pointed them to this ticket as they are the ones who can make a call on this.
#7
@
20 months ago
@peterwilsoncc, the design lead(s) requested and approved this change. It would be great if we could land this in WP 6.2.
#10
@
20 months ago
The reasonings are shared here https://github.com/WordPress/gutenberg/pull/48934#issuecomment-1461672012
I'd say it's fairly important. Reason being that template descriptions are given elevated prominence in the Site Editor now
Will discuss this during the pre-RC1 scrub happening in about 20 minutes in Make/Core slack.
This ticket was mentioned in Slack in #core by costdev. View the logs.
20 months ago
#13
@
20 months ago
Discussed during today's pre-RC1 scrub:
There is consensus to commit these change as they improve the UX in the Site Editor and 6.2 makes these template descriptions more prominent.
Props @SergeyBiryukov @davidbaumwald for discussing.
#14
@
20 months ago
- Description modified (diff)
- Keywords commit added
- Summary changed from Port template description updates to 6.2 to Editor: Update template description
Patch: https://github.com/WordPress/wordpress-develop/pull/4204
Ready for commit 👍 Preparing it now
#15
@
20 months ago
- Owner set to hellofromTonya
- Resolution set to fixed
- Status changed from new to closed
In 55500:
@hellofromTonya commented on PR #4204:
20 months ago
#16
Committed via https://core.trac.wordpress.org/changeset/55500.
Ports the template description changes from https://github.com/WordPress/gutenberg/pull/48934
Trac ticket: https://core.trac.wordpress.org/ticket/57892