Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #57913, comment 24


Ignore:
Timestamp:
03/20/2023 09:26:51 PM (2 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #57913, comment 24

    v1 v2  
    88> }}}
    99
    10 @aristath @manfcarlo Yep, this would work. Looking a bit more, it is very similar to what Sergey was talking about in [https://core.trac.wordpress.org/ticket/57913?replyto=23#comment:18 comment 18]. Chances are plugins and themes would probably do `remove_theme_support( 'attachment-pages' )` or `add_theme_support( 'attachment-pages' )` on every page load as that would be most compatible (but will be one more function call).
     10@aristath @manfcarlo Yep, this would work. Looking a bit more, it is pretty similar to what Sergey was talking about in [https://core.trac.wordpress.org/ticket/57913?replyto=23#comment:18 comment 18]. Chances are plugins and themes would probably do `remove_theme_support( 'attachment-pages' )` or `add_theme_support( 'attachment-pages' )` on every page load as that would be most compatible (but will be one more function call).
    1111
    1212This also makes the "theme_support" part somewhat useless as it will be dependent on the option. So maybe WP can just use the `wp_attachment_pages_enabled` option and set it to `true` for existing sites and `false` for new installs. Then everybody will be able to update it as needed (hopefully just once) on plugin/theme activation.