WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#57919 closed defect (bug) (duplicate)

sprintf() needs more than 1 arguments

Reported by: aristath Owned by:
Priority: normal Milestone:
Component: Comments Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

This is a backport of ​https://github.com/WordPress/gutenberg/pull/49054, reported in ​https://github.com/WordPress/gutenberg/issues/49000

In src/wp-includes/blocks/comment-template.php we have $block_content .= sprintf( $inner_content ); which will throw a PHP error because sprintf() expects at least 2 arguments.

Change History (6)

This ticket was mentioned in ​PR #4232 on ​WordPress/wordpress-develop by ​@aristath.
4 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/57919

#2 @ocean90
4 years ago

  • Milestone 6.2
  • Resolution → duplicate
  • Status new → closed

While this already has a PR assigned I'm going to mark it as a duplicate of #57883 since it has a few more details.

​@audrasjb commented on ​PR #4232:
4 years ago #3

Hey @aristath thanks for the PR but AFAIK, this file shouldn't be edited directly in Core. This probably has to be fixed on Gutenberg's side only and merged into Core via a package update.

​@aristath commented on ​PR #4232:
4 years ago #4

I wasn't clear on the process now that we're on RC, that's why I created the separate PR for Core... Just in case it's too late for automated package updates (there's a lot of confusion around what goes where, until when etc)

​@Mamaduka commented on ​PR #4232:
4 years ago #5

The changes will be part of the package update. We can close this PR and related Trac ticket.

#6 @SergeyBiryukov
4 years ago

  • Component General → Comments
  • Summary sprint() needs more than 1 arguments → sprintf() needs more than 1 arguments
Note: See TracTickets for help on using tickets.