Improved format of plugin upgrade notice

[afragen]

Since the $auto_upgrade_notice has been added to the update-core.php table listing if an $upgrade_notice is present by virtue of the readme.txt containing data in the == Upgrade Notice == section this text will appear in between the compatibility information and the auto update information. This provides a less consistent appearance.

I propose moving the upgrade notice information after the auto update information.

Related: #34986

Since the $auto_upgrade_notice has been added to the update-core.php table listing if an $upgrade_notice is present by virtue of the readme.txt containing data in the == Upgrade Notice == section this text will appear in between the compatibility information and the auto update information. This provides a less consistent appearance

Trac ticket: https://core.trac.wordpress.org/ticket/57939

[costdev]

Hey @afragen, could you add some testing instructions so this can be picked up by the Test Team? Thanks!

[costdev]

Testing Instructions

These steps define how to test the enhancement, and indicates the expected behavior or results. Provided by Andy in Slack DM.

Steps to Test

1. Install and activate the test plugin.
2. Navigate to Plugins > Installed Plugins and click Enable auto-updates beside one of your existing plugins.
3. Decrease that plugin's Version header in its main file (e.g. plugins/akismet/akismet.php) so that an update shows.
4. Navigate to Dashboard > Updates and examine the plugin's row in the update table.
5. Apply the PR.
6. Refresh the Dashboard > Updates screen and examine the plugin's row again.

Expected Results

• ✅ Before the PR: The upgrade notice should appear between the compatibility information and the auto-update information.
• ✅ After the PR: The upgrade notice should appear after the auto-update information.

[costdev]

Test plugin: Adds an $upgrade_notice key for all plugin updates.

[zunaid321]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: ​https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/4242.diff

Environment

• OS: Windows 11 (22H2)
• Web Server: nginx/1.23.4
• PHP: 7.4.33
• WordPress: 6.3-alpha-55505-src
• Browser: Chrome Version 114.0.5735.110 (Official Build) (64-bit)
• Theme: Twenty Twenty-Three

Before Applying The Patch

• Followed the instructions of @costdev
• The upgrade notice appeared between the compatibility information and the auto-update information.

After Applying The Patch

• Followed the same instructions
• ✅ The upgrade notice appeared after the auto-update information.

Plugins Used

• Attached: 57939-force-upgrade-notice.zip
• Redirection - ​https://wordpress.org/plugins/redirection/

Screenshots

• Before Patch: ​https://prnt.sc/vrF5mnZoTohD
• After Patch: ​https://prnt.sc/pSEDz6EBqWOO

[costdev]

Thanks for testing @zunaid321!

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: ​https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/4242.diff

Environment

• WordPress: 6.3-alpha-55505
• PHP: 7.4.33
• Server: Apache/2.4.56 (Ubuntu)
• Database: mysqli (Server: 5.7.41-0ubuntu0.18.04.1 / Client: mysqlnd 7.4.33)
• Browser: Chrome 114.0.0.0 (Windows 10/11)
• Theme: Twenty Twenty-Three 1.1
• MU-Plugins: None activated.
• Plugins:
  • Add an upgrade notice to all plugin updates. 1.0.0

Actual Results

• ✅ Before the PR: The upgrade notice appeared between the compatibility information and the auto-update information.
• ✅ After the PR: The upgrade notice appeared after the auto-update information.

Additional Notes

• This has two confirming test reports now. Removing needs-testing.
• This is a straightforward patch and change. Adding for commit consideration.

[audrasjb]

In 56001:

Upgrade/Install: Move location of $upgrade_notice for better consistency.

Since the $auto_upgrade_notice has been added to the update-core.php table listing if an $upgrade_notice is present by virtue of the readme.txt
containing data in the == Upgrade Notice == section, this text will appear in between the compatibility information and the auto update information.

This changeset provides a more consistent appearance in the interface.

Props afragen, costdev, zunaid321.
Fixes #57939.

committed in https://core.trac.wordpress.org/changeset/56001