Deprecated jQuery in Farbtastic

[Malae]

jQuery.fn.mousedown() event shorthand is deprecated in /wp-admin/js/farbtastic.js
jQuery.fn.bind() is deprecated in /wp-admin/js/farbtastic.js

[sabernhardt]

Thanks for the report!

Usually, external library issues should be reported upstream, but the ​Farbtastic GitHub repo does not have recent activity.

This script was moved to the js folder in [43309], though the most recent content change was [16305].

[SergeyBiryukov]

The upstream repository has been archived by the owner on Feb 27, 2019, and is now read-only.

Looks like this will now be an "adopted" library, and can be patched with necessary changes.

[Presskopp]

​Farbtastic itself is long dead. But it still is to find in the Twenty Eleven Theme and some remnants are still to find in Core. Instead of patching it, we should completely get rid of it, I'd say.

Trac ticket: 57946

[peterwilsoncc]

I don't think it's possible to remove the library as it's used by ​many plugins (a few false positives in there) and ​quite a few themes.

One of the true positives is CMB2 which is used by many more sites than the install count suggests as it's often included as a package within client project themes and/or plugins.

As the library is already considered adopted by core, it's fine to modify the files in the pull request.

[oglekler]

If we cannot remove this library, we need to adopt it and this ticket needs a new patch. Due to this, I am moving this into the 6.4 milestone.

[mrinal013]

@peterwilsoncc
Just change some code of the core Farbtastic.js library. So further testing is required.

[oglekler]

Because patch is now ready for testing and this ticket was in 6.3 milestone, I am returning it to this milestone.

Reopen PR

Reopen PR

Reopen PR

Trac ticket: https://core.trac.wordpress.org/ticket/57946

[mrinal013]

Removed need-dev-note and reporter-feedback. Because I think they are not appropriate now.

[mrinal013]

Replacement of the old fabrasic.js

[sabernhardt]

replace old jQuery methods and add documentation notes

[sabernhardt]

Note: I did not test the patch. I simply reduced the changes, mainly so it's easier to review.

[mrinal013]

Replying to sabernhardt:

Note: I did not test the patch. I simply reduced the changes, mainly so it's easier to review.

Thanks.

In https://core.trac.wordpress.org/attachment/ticket/57946/57946.patch, I did somehow similar changes as https://core.trac.wordpress.org/attachment/ticket/57946/57946.1.patch. Additionally, in https://core.trac.wordpress.org/attachment/ticket/57946/57946.patch,

1. Following coding standard, added with wp-prettier.
2. Use navigator.userAgent instead of navigator.appVersion, since navigator.appVersion is not recommended ​https://developer.mozilla.org/en-US/docs/Web/API/Navigator/appVersion.

[jorbin]

Following coding standard, added with wp-prettier.

This adds alot of unnecessary changes which are harder to review and also mean that if fabrasic ever comes back from the dead, it would really hard to upstream these changes.

[mrinal013]

Replying to jorbin:

Following coding standard, added with wp-prettier.

This adds alot of unnecessary changes which are harder to review and also mean that if fabrasic ever comes back from the dead, it would really hard to upstream these changes.

Like this idea.

Also, tested the patch: https://core.trac.wordpress.org/attachment/ticket/57946/57946.1.patch

It works ok on my end.

[audrasjb]

self assigning for commit

[sabernhardt]

If navigator.appVersion should (ever) be removed, too, I think it could be better to remove the full IE6 PNG background section.

[audrasjb]

In 56252:

External Libraries: Update deprecated jQuery code in Farbtastic lib.

This changeset updates some deprecated jQuery code in the Farbtastic external library. As this vendor script is not maintained anymore, this changeset
also adds a docblock to specify that the library has been "adopted" by WP Core.

Props Malae, sabernhardt, SergeyBiryukov, Presskopp, mrinal013, peterwilsoncc, oglekler, jorbin.
Fixes #57946.