Make WordPress Core

Opened 2 months ago

Last modified 2 weeks ago

#57977 assigned enhancement

Screen elements in dashboard - design update in small device - feature request.

Reported by: dhrumilk's profile dhrumilk Owned by: dhrumilk's profile dhrumilk
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: needs-design-feedback has-screenshots good-first-bug has-patch
Focuses: ui, css Cc:

Description

we need to update the design for the screen option check box in small devices to look good for the small device user.

we need to set the checkbox in 2 columns.

Dashboard > home > click on the screen option.

Attachments (8)

before design.png (39.1 KB) - added by dhrumilk 2 months ago.
after design.png (32.7 KB) - added by dhrumilk 2 months ago.
core57977.diff (1.1 KB) - added by prashantbhivsane 4 weeks ago.
screenshot-resp.png (14.5 KB) - added by prashantbhivsane 4 weeks ago.
braked design ss.png (47.2 KB) - added by dhrumilk 4 weeks ago.
@prashantbhivsane applied patch design screen short. (It's not working fine).
screen options.png (42.4 KB) - added by ababir 2 weeks ago.
For small screen, Screen Option check box can stack up like this to make it more easy to use in mobile device.
core57977-new.diff (399 bytes) - added by prashantbhivsane 2 weeks ago.
57977.diff (2.7 KB) - added by chiragrathod103 2 weeks ago.
Diff with the responsive CSS should apply

Download all attachments as: .zip

Change History (31)

#1 @dhrumilk
2 months ago

  • Summary changed from Screen elements in dashboard - design update in small device. to Screen elements in dashboard - design update in small device - feature request.

#2 @oglekler
4 weeks ago

  • Component changed from Administration to Help/About
  • Focuses css added
  • Keywords needs-patch has-screenshots good-first-bug added; reporter-feedback dev-feedback removed

#3 @prashantbhivsane
4 weeks ago

  • Keywords has-patch reporter-feedback added; needs-patch removed

#4 @prashantbhivsane
4 weeks ago

@oglekler can this be assigned to me?

This ticket was mentioned in PR #4437 on WordPress/wordpress-develop by @prashantbhivsane.


4 weeks ago
#5

Added a 2x2 grid for the screen options preferences for smaller screens.

#57977

#6 @marybaum
4 weeks ago

  • Milestone changed from Awaiting Review to 6.3
  • Owner set to dhrumilk
  • Status changed from new to assigned

Welcome! I agree with you, and while I just told Olga I'd be happy to make a patch, I'm just as happy to assign this to you. I see you already have a patch — great! Next step, then, is testing. We will test your patch, and I invite you to invite all your friends to test it as well — in a local installation you use for development and testing, of course!

#7 @prashantbhivsane
4 weeks ago

@dhrumilk could you please test the patch and let me know if there's any feeedback?

#8 @dhrumilk
4 weeks ago

  • Keywords needs-patch added; has-patch removed

@prashantbhivsane I have checked your patch and also apply on my local but it's not working fine it's breaking the other design. Also, I have added braked design Screen short.

@dhrumilk
4 weeks ago

@prashantbhivsane applied patch design screen short. (It's not working fine).

#9 @prashantbhivsane
4 weeks ago

@dhrumilk could you provide the following? :

  1. Plugins you have installed 2. Theme you are using

#10 @dhruvishah2203
4 weeks ago

@prashantbhivsane
It's not working on my pc as well. Please check the screenshot given below.
Screenshot : https://prnt.sc/9lh9QqenoYm2

#11 @dhrumilk
4 weeks ago

@prashantbhivsane I have checked again by removing all plugins and using the Twenty Twenty-Two wordpress theme but it's not working fine and it looks like the current design. but yes I have removed all plugins so the above design is fixed.

Currently, your patch looks like same as the @dhruvishah2203 screenshot.

#12 @prashantbhivsane
4 weeks ago

@dhruvishah2203 @dhrumilk would you let me know how you applied the patch? as it is a CSS change (common.css), it should be reflected in the minified css after building the WP

common.min.css
Last edited 4 weeks ago by prashantbhivsane (previous) (diff)

#13 @dhrumilk
4 weeks ago

  • Keywords has-patch added; needs-patch removed

@prashantbhivsane oho sorry I forgot to run my docker. and yes your Patch is working fine for me.
Thank you for correcting me.

#14 @prashantbhivsane
4 weeks ago

@dhrumilk no worries!

#15 @dhrumilk
4 weeks ago

  • Keywords reporter-feedback removed

@ababir
2 weeks ago

For small screen, Screen Option check box can stack up like this to make it more easy to use in mobile device.

#16 follow-up: @prashantbhivsane
2 weeks ago

hi @ababir that looks good, but would not that mean screen would have to be scrolled more for additional items? stacking in 2 columns will halve that scrolling.

#17 in reply to: ↑ 16 @ababir
2 weeks ago

Replying to prashantbhivsane:

hi @ababir that looks good, but would not that mean screen would have to be scrolled more for additional items? stacking in 2 columns will halve that scrolling.

Hello @prashantbhivsane. You are absolutely right about the scrolling part. Thank you for pointing it out. You have to scroll a bit for additional items. But what I was thinking is this particular section is hidden by default, as this is a drop-down. So, this might not be an issue. On top of that, it will give a clean UI to interact with on a smaller device.

#18 @dhrumilk
2 weeks ago

@ababir Your screenshot is more looks good to me. and also it will not create issues in user experience because of the dropdown.
So can you create the diff file for that?

#19 @prashantbhivsane
2 weeks ago

@ababir agree with you, I will update the patch.

#21 @dhrumilk
2 weeks ago

@prashantbhivsane I have verified your PR there are some minor changes. we need to apply CSS for the small device only current will apply for all devices.

@chiragrathod103
2 weeks ago

Diff with the responsive CSS should apply

#22 @dhrumilk
2 weeks ago

57977.diff looks good to me.

Note: See TracTickets for help on using tickets.