Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 weeks ago

#58004 closed defect (bug) (reported-upstream)

not possible to change default margin for <footer>

Reported by: thomask's profile thomask Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.2
Component: Editor Keywords:
Focuses: Cc:

Description

Footer element is affected by global block style (in twenty-three-theme, as probably the most others site edit gutenberg themes)

.wp-site-blocks > * + * {
    margin-block-start: 1.5rem;
}

but the footer element itself do not have option to change margin. So the only way how anyone can change/delete this margin is to add the extra definition for footer to the stylesheet, what is somehow against the gutenberg principes IMO.

the same is for header element, but there is no default margin (as this css one affect all but the first one), but i guess if there would be a change for footer block, it should be for header as well

It is a problem when you got different background for the last block before the footer - it creates a white 1.5rem wide line between this block and footer, so maybe it should be omited for footer by default anyway

Change History (4)

#1 follow-up: @costdev
6 months ago

  • Keywords reporter-feedback added

Hi @thomask, thanks for opening this ticket.

This appears to be the same issue reported upstream on the Gutenberg repository: https://github.com/WordPress/gutenberg/issues/47637

Can you confirm whether this is the same issue? If so, we can close this ticket as reported-upstream.

#2 @costdev
6 months ago

  • Component changed from General to Editor

#3 in reply to: ↑ 1 @thomask
6 months ago

  • Resolution set to reported-upstream
  • Status changed from new to closed

Replying to costdev:

Can you confirm whether this is the same issue? If so, we can close this ticket as reported-upstream.

yep, thank you, it is the same issue, i am closing it

#4 @desrosj
6 weeks ago

  • Keywords needs-patch reporter-feedback removed
  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.