WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 5 years ago

#5802 closed defect (bug) (fixed)

Make RSS Default Consistent

Reported by: filosofo Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.8
Component: Feeds Keywords: has-patch
Focuses: Cc:

Description

Currently get_default_feed() returns rss2 (RSS 2.0), but get_the_category_rss() has as default "rss--i.e. RSS 0.92--as the default.

Also, if you request "rss," either by /?feed=rss or /feed/rss/, the response is in RSS 0.92 format. To get RSS 2.0 you either have to request rss2 specifically or feed=feed.

Since RSS 2.0 is what you get from get_default_feed(), and because it's newer and has more features than RSS 0.92, it seems to me that default "rss" (?feed=rss or /feed/rss/) should be RSS 2.0, not 0.92 as it is now.

The attached patch:

  • Makes "rss" RSS 2.0
  • Lets you specify RSS 0.92 with rss092
  • Makes the default value for get_the_category_rss() be whatever get_default_feed() returns

Attachments (2)

make_rss2_default.diff (4.2 KB) - added by filosofo 7 years ago.
5802.patch (1.1 KB) - added by peaceablewhale 6 years ago.

Download all attachments as: .zip

Change History (14)

@filosofo7 years ago

comment:1 @Denis-de-Bernardy6 years ago

  • Component changed from General to Feeds
  • Owner anonymous deleted

comment:2 @peaceablewhale6 years ago

  • Keywords dev-feedback added; RSS rss2 rss092 feed removed
  • Milestone changed from 2.9 to 2.8
  • Version set to 2.8

I am going to attach a new patch that fixes get_the_category_rss and the_category_rss within next minute. However, I don't want to have rss092 as I really want to have it removed. Please refer to http://core.trac.wordpress.org/ticket/4967#comment:11 for details.

@peaceablewhale6 years ago

comment:3 follow-up: @Denis-de-Bernardy6 years ago

  • Keywords dev-feedback removed

shouldn't we change the default directly?

comment:5 @Denis-de-Bernardy6 years ago

  • Milestone changed from 2.8 to 2.9

punting per IRC discussion

comment:6 in reply to: ↑ 3 @peaceablewhale6 years ago

Replying to Denis-de-Bernardy:

shouldn't we change the default directly?

Do you mean that you want to hard-code "rss2" to the functions?

comment:8 @peaceablewhale6 years ago

However, the default feed format can be changed by admin using a plugin. I think the user's preferred format should be the default.

comment:9 @Denis-de-Bernardy6 years ago

Was mostly asking for reference (both make sense to me).

comment:10 @Denis-de-Bernardy6 years ago

patch still applies clean

comment:12 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12197]) Ue get_default_feed() for *_the_category_rss(). Props filosofo, peaceablewhale. fixes #5802

Note: See TracTickets for help on using tickets.