Changes between Initial Version and Version 1 of Ticket #58027, comment 1
- Timestamp:
- 03/30/2023 10:30:02 PM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #58027, comment 1
initial v1 3 3 I also would like to add that this bug is not actually new. While the logic was added to the `post-featured-image` block in 6.2, it was directly taken over from the same code being in the `post-content` block. If you put the same code from your snippet but with the `post-content` block, you'll see the same problem occur. While I would love to understand better where this realistically is a problem, I certainly agree that that logic feels clunky, and I am not sure why it's there. 4 4 5 The logic (i.e. also the bug) has been in that block since it was originally added in WordPress 5.8 (introduced as part of [50929] and [51344]). Digging further, it looks like the original logic was introduced in https://github.com/WordPress/gutenberg/pull/30405. Acknowledging that this was added almost 2 years ago, @aristath @ntsekouras do you have any memory on why enforcing a loop was added in th at post? Shouldn't we rather make sure, outside of that block, that it is used within a loop?5 The logic (i.e. also the bug) has been in that block since it was originally added in WordPress 5.8 (introduced as part of [50929] and [51344]). Digging further, it looks like the original logic was introduced in https://github.com/WordPress/gutenberg/pull/30405. Acknowledging that this was added almost 2 years ago, @aristath @ntsekouras do you have any memory on why enforcing a loop was added in the `core/post-content` block? Shouldn't we rather make sure, outside of that block, that it is used within a loop?