Fix non-strictly checking issue on line 1014 of schema.php

[faisalahammad]

I found a non-strictly checking issue on line 1014 from the /wp-admin/includes/schema.php file in WordPress. To fix this issue, we need to replace the == operator with the === operator, which ensures that the values being compared are of the same type. This will help to prevent potential bugs and improve the overall security of the code. Thank you!

Source code:

<?php
if ( 1 == $network_id ) {
        $wpdb->insert(
                $wpdb->site,
                array(
                        'domain' => $domain,
                        'path'   => $path,
                )
        );
        $network_id = $wpdb->insert_id;
} else {
        $wpdb->insert(
                $wpdb->site,
                array(
                        'domain' => $domain,
                        'path'   => $path,
                        'id'     => $network_id,
                )
        );
}

I found a non-strictly checking issue on line 1014 of the schema.php file in WordPress. To fix this issue, I replaced the == operator with the === operator, which ensures that the values being compared are of the same type. This will help to prevent potential bugs and improve the overall security of the code. Please review and merge this pull request. Thank you!

Trac ticket: https://core.trac.wordpress.org/ticket/58042

[SergeyBiryukov]

In 55866:

Coding Standards: Use strict comparison in wp-admin/includes/schema.php.

Follow-up to [12756], [12862], [12880], [13070], [14485], [17928], [18899], [41348], [43628].

Props faisalahammad, aristath, poena, afercia, SergeyBiryukov.
Fixes #58042, #58047. See #57839.

Thanks for the PR! Merged in r55866.

Looks like I accidentally missed the props for @audrasjb here, sorry for that! I have updated the props for that commit in the Core Props tool on make/core to fix that.

do we need a doing it wrong notice here?

No, I don't think it's needed. Taking a closer look, populate_network_meta() uses a type cast to int early in the function, so I used the same approach here 🙂