Opened 18 months ago
Closed 17 months ago
#58054 closed defect (bug) (wontfix)
Add spaces before and after function parameters in all functions in class-ftp-pure.php file.
Reported by: | faisalahammad | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Filesystem API | Keywords: | |
Focuses: | coding-standards | Cc: |
Description
Improving the readability and adherence to the WordPress coding standards in the wp-admin/includes/class-ftp-pure.php file from the various function, there is currently no space before and after the function parameters, which goes against the WordPress coding standards.
To fix this issue, I propose adding spaces before and after the function parameters in all functions. This will make the code more readable and consistent with WordPress coding standards.
Change History (6)
This ticket was mentioned in PR #4287 on WordPress/wordpress-develop by @faisalahammad.
18 months ago
#1
- Keywords has-patch added; needs-patch removed
#2
follow-up:
↓ 3
@
18 months ago
- Version 6.2 deleted
Hello and thank you for the ticket and patch,
Worth noting that this file comes from an upstream library so we need to confirm it is completely adopted by WP Core before fixing the various WPCS issues.
#3
in reply to:
↑ 2
@
18 months ago
- Keywords has-patch removed
Replying to audrasjb:
Worth noting that this file comes from an upstream library
Yep, seems the correct patch here is to exclude this file from WPCS coding standards checks, but not the other/compat checks.
#4
@
17 months ago
- Keywords close added
The file already is excluded from the WPCS checks, so this is a non-issue.
@SergeyBiryukov commented on PR #4287:
17 months ago
#5
Thanks for the PR!
As noted on the ticket, this file is part of an external library that has only been patched on rare occasions, and is excluded from coding standards checks.
This PR ticket is about improving the readability and adherence to the WordPress coding standards in the
wp-admin/includes/class-ftp-pure.php
file. There is currently no space before and after the function parameters, which goes against the WordPress coding standards.To fix this issue, I propose adding spaces before and after all function parameters. This will make the code more readable and consistent with WordPress coding standards.
I believe that this change will improve the overall quality of the codebase and make it easier for developers to understand and maintain the code.
Trac ticket: https://core.trac.wordpress.org/ticket/58054