Make WordPress Core

Opened 13 months ago

Last modified 13 months ago

#58058 new defect (bug)

Fix PHP open and close tag placement in /wp-admin/comment.php LineNo 175

Reported by: moinrrahmed's profile moinrrahmed Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch changes-requested
Focuses: coding-standards Cc:

Description

This PR fixes a PHP open and close tag placement issue on line 175 of the WordPress file /wp-admin/comment.php. The original code embeds a multi-line PHP snippet within an HTML block, but the PHP open tag is not on a line by itself. The updated code moves the PHP open tag to a new line so that it is on a line by itself, as required by best practices. This improves the readability and maintainability of the WordPress core codebase.

Change History (2)

This ticket was mentioned in PR #4290 on WordPress/wordpress-develop by @moinrrahmed.


13 months ago
#1

  • Keywords has-patch added; needs-patch removed

This PR fixes a PHP open and close tag placement issue on line 175 of the WordPress file /wp-admin/comment.php. The original code embeds a multi-line PHP snippet within an HTML block, but the PHP open tag is not on a line by itself. The updated code moves the PHP open tag to a new line so that it is on a line by itself, as required by best practices. This improves the readability and maintainability of the WordPress core codebase.

Trac ticket: https://core.trac.wordpress.org/ticket/58058

#2 @audrasjb
13 months ago

  • Component changed from General to Comments
  • Keywords changes-requested added
  • Version trunk deleted

Hello and thanks for the ticket and patch,

FWIW, it appears there are some unrelated changes in your PR (code indentation) and these changes are triggering some coding standards issues.

Note: See TracTickets for help on using tickets.