Make WordPress Core

Opened 16 months ago

Last modified 6 days ago

#58100 assigned defect (bug)

Twenty Nineteen: PullQuote block color is not reflected on citation text

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 6.2
Component: Bundled Theme Keywords: has-patch has-testing-info has-screenshots changes-requested
Focuses: css Cc:

Description

Steps to reproduce the issue :-

  1. Activate Twenty Nineteen theme.
  2. Choose Pullquote block.
  3. Add some text.
  4. Apply text color.

You can able to see that text color is not reflected on the citation text.
I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/tcxjFQrzTyDgzzTN4yjR

Attachments (1)

58100.patch (1.9 KB) - added by nidhidhandhukiya 16 months ago.

Download all attachments as: .zip

Change History (11)

#1 @kelvinballoo
16 months ago

I was able to simulate this also.

Environment

WordPress: 6.2
PHP: 7.4
Browser: Version 112.0.5615.49 (Official Build) (x86_64)
Theme: 2023 and 2019
Language : EN
Device: MacBook Pro (Retina, 15-inch, Mid 2015)
OS: MacOS Monterey 12.6.3


Steps to Reproduce

(I am putting the steps differently so that it's easier to see how it is supposed to work first)

  1. With 'Twenty Twenty-Three' Theme installed, Go to Posts > Add New and create a new post.
  2. Add the Pullquote block.
  3. Add some text.
  4. Apply colour to the text.
    Notice that both the quote and the citation change colour
    
  5. Activate Twenty Nineteen Theme
  6. Go to the post editor and change the colour of the text
    Notice that only the quote changes colour and not the citation
    

Expected Results:

Both quote and citation should change colour


Actual Results:

Only quote is changing colour in Twenty Nineteen theme.

Note: I've tested this on other themes as from 2019 to 2023 and only 2019 seems to have the issue.

Last edited 16 months ago by kelvinballoo (previous) (diff)

This ticket was mentioned in Slack in #core-test by ironprogrammer. View the logs.


15 months ago

#3 @Ankit K Gupta
15 months ago

  • Keywords has-patch has-testing-info added

#4 @Ankit K Gupta
15 months ago

  • Keywords has-screenshots needs-testing added

#5 @pooja1210
15 months ago

Hi,

Test Report for - https://core.trac.wordpress.org/attachment/ticket/58100/58100.patch

Environment:
WordPress - V6.2
Theme: Twenty Nineteen
OS: Mac
Browser: Chrome

Expected Result:
Color should be apply for both Quote title and citation ☑️

Actual Result:
Only Quote title color is changing.

Screenshots:
Before applying Patch - https://prnt.sc/8y44v7GPPTSt

After applying Patch - https://prnt.sc/dRgkgkV1y0Xz

Thanks!

#6 @karmatosed
8 days ago

  • Milestone changed from Awaiting Review to 6.7
  • Owner set to karmatosed
  • Status changed from new to assigned

As we have fixed other themes for pullquote up until now I am going to go ahead and do this. However, I am going to note that the plan is to consider moving to just one quote block in the future.

#7 @karmatosed
8 days ago

  • Keywords commit added

Adding commit as in testing I can confirm that this works for me and I am going to commit it.

#8 @karmatosed
8 days ago

  • Keywords changes-requested added; commit removed

Unfortunately it looks like I can't commit this as when I compile the Sass it is only adding to the rtl.css and it is removing the other css. My recommendation would be to provide a refreshed PR with the Sass also.

#9 @sabernhardt
7 days ago

  • Focuses css added
  • Keywords needs-testing removed
  • Milestone changed from 6.7 to Future Release
  • Summary changed from Twenty Nineteen :- PullQuote block color is not reflacted on citation text to Twenty Nineteen: PullQuote block color is not reflected on citation text

58100.patch replaces the theme's value of #767676 with inherit, which would also change the default color to match the paragraph (#000) when it should be lighter. The citation should only inherit the block's color when someone selects a text and/or background color.

#10 @karmatosed
6 days ago

  • Owner karmatosed deleted
Note: See TracTickets for help on using tickets.