Opened 18 months ago
Last modified 3 months ago
#58100 assigned defect (bug)
Twenty Nineteen: PullQuote block color is not reflected on citation text
Reported by: | nidhidhandhukiya | Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | 6.2 |
Component: | Bundled Theme | Keywords: | has-patch has-testing-info has-screenshots changes-requested |
Focuses: | css | Cc: |
Description
Steps to reproduce the issue :-
- Activate Twenty Nineteen theme.
- Choose Pullquote block.
- Add some text.
- Apply text color.
You can able to see that text color is not reflected on the citation text.
I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/tcxjFQrzTyDgzzTN4yjR
Attachments (1)
Change History (11)
This ticket was mentioned in Slack in #core-test by ironprogrammer. View the logs.
18 months ago
#5
@
18 months ago
Hi,
Test Report for - https://core.trac.wordpress.org/attachment/ticket/58100/58100.patch
Environment:
WordPress - V6.2
Theme: Twenty Nineteen
OS: Mac
Browser: Chrome
Expected Result:
Color should be apply for both Quote title and citation ☑️
Actual Result:
Only Quote title color is changing.
Screenshots:
Before applying Patch - https://prnt.sc/8y44v7GPPTSt
After applying Patch - https://prnt.sc/dRgkgkV1y0Xz
Thanks!
#6
@
3 months ago
- Milestone changed from Awaiting Review to 6.7
- Owner set to karmatosed
- Status changed from new to assigned
As we have fixed other themes for pullquote up until now I am going to go ahead and do this. However, I am going to note that the plan is to consider moving to just one quote block in the future.
#7
@
3 months ago
- Keywords commit added
Adding commit as in testing I can confirm that this works for me and I am going to commit it.
#8
@
3 months ago
- Keywords changes-requested added; commit removed
Unfortunately it looks like I can't commit this as when I compile the Sass it is only adding to the rtl.css and it is removing the other css. My recommendation would be to provide a refreshed PR with the Sass also.
#9
@
3 months ago
- Focuses css added
- Keywords needs-testing removed
- Milestone changed from 6.7 to Future Release
- Summary changed from Twenty Nineteen :- PullQuote block color is not reflacted on citation text to Twenty Nineteen: PullQuote block color is not reflected on citation text
58100.patch replaces the theme's value of #767676
with inherit
, which would also change the default color to match the paragraph (#000
) when it should be lighter. The citation should only inherit the block's color when someone selects a text and/or background color.
I was able to simulate this also.
Environment
WordPress: 6.2
PHP: 7.4
Browser: Version 112.0.5615.49 (Official Build) (x86_64)
Theme: 2023 and 2019
Language : EN
Device: MacBook Pro (Retina, 15-inch, Mid 2015)
OS: MacOS Monterey 12.6.3
Steps to Reproduce
(I am putting the steps differently so that it's easier to see how it is supposed to work first)
Expected Results:
Both quote and citation should change colour
Actual Results:
Only quote is changing colour in Twenty Nineteen theme.
Note: I've tested this on other themes as from 2019 to 2023 and only 2019 seems to have the issue.