Twenty Nineteen: PullQuote block color is not reflected on citation text

[nidhidhandhukiya]

Steps to reproduce the issue :-

1. Activate Twenty Nineteen theme.
2. Choose Pullquote block.
3. Add some text.
4. Apply text color.

You can able to see that text color is not reflected on the citation text.
I have attached video for better understanding.
Video URL :- ​https://share.cleanshot.com/tcxjFQrzTyDgzzTN4yjR

[kelvinballoo]

I was able to simulate this also.

Environment

WordPress: 6.2
PHP: 7.4
Browser: Version 112.0.5615.49 (Official Build) (x86_64)
Theme: 2023 and 2019
Language : EN
Device: MacBook Pro (Retina, 15-inch, Mid 2015)
OS: MacOS Monterey 12.6.3

---

Steps to Reproduce

(I am putting the steps differently so that it's easier to see how it is supposed to work first)

1. With 'Twenty Twenty-Three' Theme installed, Go to Posts > Add New and create a new post.
2. Add the Pullquote block.
3. Add some text.
4. Apply colour to the text.

   Notice that both the quote and the citation change colour
   

5. Activate Twenty Nineteen Theme
6. Go to the post editor and change the colour of the text

   Notice that only the quote changes colour and not the citation
   

---

Expected Results:

Both quote and citation should change colour

---

Actual Results:

Only quote is changing colour in Twenty Nineteen theme.

[pooja1210]

Hi,

Test Report for - https://core.trac.wordpress.org/attachment/ticket/58100/58100.patch

Environment:
WordPress - V6.2
Theme: Twenty Nineteen
OS: Mac
Browser: Chrome

Expected Result:
Color should be apply for both Quote title and citation ☑️

Actual Result:
Only Quote title color is changing.

Screenshots:
Before applying Patch - ​https://prnt.sc/8y44v7GPPTSt

After applying Patch - ​https://prnt.sc/dRgkgkV1y0Xz

Thanks!

[karmatosed]

As we have fixed other themes for pullquote up until now I am going to go ahead and do this. However, I am going to note that the plan is to consider moving to just one quote block in the future.

[karmatosed]

Adding commit as in testing I can confirm that this works for me and I am going to commit it.

[karmatosed]

Unfortunately it looks like I can't commit this as when I compile the Sass it is only adding to the rtl.css and it is removing the other css. My recommendation would be to provide a refreshed PR with the Sass also.

[sabernhardt]

58100.patch replaces the theme's value of #767676 with inherit, which would also change the default color to match the paragraph (#000) when it should be lighter. The citation should only inherit the block's color when someone selects a text and/or background color.

Trac ticket: #58100

[sandeepdahiya]

Test Report

Description

✅ This report validates that the indicated patch works as expected.

Patch tested: ​Patch-8994.diff

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.28
• Server: nginx/1.27.5
• Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
• Browser: Firefox 139.0
• OS: Windows 11
• Theme: Twenty Nineteen
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

After patch:

• ✅ The patch worked as expected
• ✅ Citation inherits the custom color only when applied. ​Checkout this screenshot.
• ✅ When no custom color is applied, citation remains #767676 as intended. ​Checkout this screenshot.
• ✅ works as expected when background color is applied without changing the text color. ​Checkout this image.
• ✅ works as expected when background color is applied and text color is also changed. ​Checkout this image.