WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#58101 closed defect (bug) (wontfix)

Remove the Unused variables in the wp-includes folder.

Reported by: upadalavipul Owned by:
Priority: normal Milestone:
Component: External Libraries Version:
Severity: normal Keywords: close
Cc: Focuses: coding-standards

Description

I have reviewed the code and found Unused variables in some of the below files. Please below files:

Files:

  1. wp-includes/ID3/module.audio-video.quicktime.php
  2. wp-includes/ID3/module.tag.lyrics3.php

Attachments (1)

58101.patch​ (1.8 KB ) - added by upadalavipul 3 years ago.

Download all attachments as: .zip

Change History (3)

@upadalavipul
3 years ago

#1 @audrasjb
3 years ago

  • Component General → External Libraries
  • Keywords close added
  • Version trunk

Hello and thanks for the ticket/patch,
However these files are part of the ID3 external library so the issue should be reported upstream:
​https://github.com/JamesHeinrich/getID3

Last edited 3 years ago by audrasjb (previous) (diff)

#2 @SergeyBiryukov
3 years ago

  • Milestone Awaiting Review
  • Resolution → wontfix
  • Status new → closed

Hi there, thanks for the patch!

As noted above, GetID3 is an external library and should not be patched here, any suggested changes to its files should be submitted upstream.

Note: See TracTickets for help on using tickets.