wp-admin/edit-comments.php unnecessarily checks twice for user permissions

[hansengel]

It's easier to just show you the current code (as of [6772]):

    <td><?php if ( current_user_can('edit_post', $comment->comment_post_ID) ) {
	echo "<a href='comment.php?action=editcomment&amp;c=$comment->comment_ID' class='edit'>" .  __('Edit') . "</a>"; } ?></td>
    <td><?php if ( current_user_can('edit_post', $comment->comment_post_ID) ) {
		$url = clean_url( wp_nonce_url( "comment.php?action=deletecomment&p=$comment->comment_post_ID&c=$comment->comment_ID", "delete-comment_$comment->comment_ID" ) );
		echo "<a href='$url' class='delete:the-comment-list:comment-$comment->comment_ID delete'>" . __('Delete') . "</a> ";
		} ?></td>

I don't see any point in repeatedly checking if the user has sufficient permissions on the same page. Let's simplify it a bit and check for user permissions once.

[hansengel]

Removes second unnecessary check for sufficient user permissions in wp-admin/edit-comments.php

[ryan]

That puts the td tags inside the conditional. I think they need to always be there even when the user doesn't have the proper caps. In that case they would be empty.

[hansengel]

Just checked it out—without my patch when the user doesn't have enough permissions, there are two empty columns at the end of each row. With the patch, they're not shown and the View link extends over where the other two columns would be. So it's actually better to use it this way, IMHO.

[westi]

Closing as FIXED as this code no longer exits in wp-admin/edit-comments.php and _wp_comment_row only checks the cap once.