Make WordPress Core

Opened 12 months ago

Closed 10 months ago

Last modified 10 months ago

#58115 closed enhancement (fixed)

Grammar improvement after signup.

Reported by: nekojonez's profile NekoJonez Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: minor Version:
Component: Login and Registration Keywords: has-patch commit
Focuses: ui-copy Cc:

Description

Currently, the phrase in wp-signup.php is:

"Check your inbox at %s and click the link given."

While I honestly think that this flows better:

"Check your inbox at %s and click on the given link."

I created a PR and also adjusted the translator comment a tiny bit to make it even more clear.

Change History (16)

This ticket was mentioned in PR #4314 on WordPress/wordpress-develop by @NekoJonez.


12 months ago
#1

  • Keywords has-patch added

Like I said in the trac ticket, I think the sentence flows a bit better now. I also adjusted the translator comment for make it even more clear.

Trac ticket: (https://core.trac.wordpress.org/ticket/58115)

#2 @kebbet
12 months ago

  • Component changed from Text Changes to Login and Registration
  • Focuses ui-copy added

#3 @SergeyBiryukov
12 months ago

  • Milestone changed from Awaiting Review to 6.3

#4 @audrasjb
12 months ago

  • Keywords changes-requested added

Thanks for the ticket. Left a small change request in the PR ;)

#5 @NekoJonez
12 months ago

  • Keywords changes-requested removed

Consider that fixed my man.

@NekoJonez commented on PR #4314:


12 months ago
#6

@audrasjb Fixed! Thanks for that feedback :D

@NekoJonez commented on PR #4314:


12 months ago
#7

@audrasjb I looked further and I found the exact same thing lower in the file... So, I fixed that as well.

This ticket was mentioned in Slack in #polyglots by nekojonez. View the logs.


12 months ago

#10 @audrasjb
12 months ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#11 @seakashdiu
12 months ago

  • Resolution set to invalid
  • Status changed from accepted to closed

I agree with @NekoJonez and the PR looks good to me.

#12 @audrasjb
12 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

This ticket was mentioned in Slack in #core by nekojonez. View the logs.


10 months ago

#14 @audrasjb
10 months ago

  • Keywords commit added

As per today's bugscrub, marking this for commit.

#15 @audrasjb
10 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 55902:

Login and Registration: Grammar improvement on Sign-up user-facing strings.

Props NekoJonez, audrasjb.
Fixes #58115.

Note: See TracTickets for help on using tickets.