WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#58115 closed enhancement (fixed)

Grammar improvement after signup.

Reported by: NekoJonez Owned by: audrasjb
Priority: normal Milestone: 6.3
Component: Login and Registration Version:
Severity: minor Keywords: has-patch commit
Cc: Focuses: ui-copy

Description

Currently, the phrase in wp-signup.php is:

"Check your inbox at %s and click the link given."

While I honestly think that this flows better:

"Check your inbox at %s and click on the given link."

I created a PR and also adjusted the translator comment a tiny bit to make it even more clear.

Change History (16)

This ticket was mentioned in ​PR #4314 on ​WordPress/wordpress-develop by ​@NekoJonez.
3 years ago #1

  • Keywords has-patch added

Like I said in the trac ticket, I think the sentence flows a bit better now. I also adjusted the translator comment for make it even more clear.

Trac ticket: (https://core.trac.wordpress.org/ticket/58115)

#2 @kebbet
3 years ago

  • Component Text Changes → Login and Registration
  • Focuses ui-copy added

#3 @SergeyBiryukov
3 years ago

  • Milestone Awaiting Review → 6.3

#4 @audrasjb
3 years ago

  • Keywords changes-requested added

Thanks for the ticket. Left a small change request in the PR ;)

#5 @NekoJonez
3 years ago

  • Keywords changes-requested removed

Consider that fixed my man.

​@NekoJonez commented on ​PR #4314:
3 years ago #6

@audrasjb Fixed! Thanks for that feedback :D

​@NekoJonez commented on ​PR #4314:
3 years ago #7

@audrasjb I looked further and I found the exact same thing lower in the file... So, I fixed that as well.

This ticket was mentioned in ​Slack in #polyglots by nekojonez. ​View the logs.
3 years ago

#10 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Status new → accepted

#11 @seakashdiu
3 years ago

  • Resolution → invalid
  • Status accepted → closed

I agree with @NekoJonez and the ​PR looks good to me.

#12 @audrasjb
3 years ago

  • Resolution invalid
  • Status closed → reopened

This ticket was mentioned in ​Slack in #core by nekojonez. ​View the logs.
3 years ago

#14 @audrasjb
3 years ago

  • Keywords commit added

As per today's bugscrub, marking this for commit.

#15 @audrasjb
3 years ago

  • Resolution → fixed
  • Status reopened → closed

In 55902:

Login and Registration: Grammar improvement on Sign-up user-facing strings.

Props NekoJonez, audrasjb.
Fixes #58115.

Note: See TracTickets for help on using tickets.