Make WordPress Core

Opened 12 months ago

Closed 12 months ago

Last modified 12 months ago

#58136 closed defect (bug) (fixed)

Give the loading spinner a little space

Reported by: presskopp's profile Presskopp Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch has-screenshots
Focuses: ui, css, administration Cc:

Description

when entering tags to a post, the loading spinner is attached to the right border. Let's give it a little more room to breath.

Looking how to patch it, the following selectors are to be touched:

input[type="text"].ui-autocomplete-loading,
input[type="email"].ui-autocomplete-loading

As a side note I wonder if the second one (email) is used at all, so maybe it just can be deleted.

Attachments (4)

loading.png (7.9 KB) - added by Presskopp 12 months ago.
58136.diff (442 bytes) - added by Presskopp 12 months ago.
6879e21835ddf523c0dc83af86935d1b.gif (60.3 KB) - added by audrasjb 12 months ago.
Before patch
205cde5c9c2a05b75913b0506bd7ec44.gif (71.5 KB) - added by audrasjb 12 months ago.
After patch: looks better!

Download all attachments as: .zip

Change History (12)

@Presskopp
12 months ago

@Presskopp
12 months ago

This ticket was mentioned in Slack in #core by oglekler. View the logs.


12 months ago

#2 @SergeyBiryukov
12 months ago

  • Focuses ui administration added
  • Milestone changed from Awaiting Review to 6.3

Hi there, thanks for the ticket!

Just to clarify, where can I find that tag input with the spinner? I've tested the one on Edit Post screen and in Quick Edit, but they look a bit different and don't seem to have a spinner.

#3 @Presskopp
12 months ago

oh sorry, it's when you use the classic editor plugin, I'm so used to it I didn't even recognize.

@audrasjb
12 months ago

After patch: looks better!

#4 @audrasjb
12 months ago

  • Keywords commit added

It indeed looks better with 58136.diff 🙂
Marking for commit.

#5 @SergeyBiryukov
12 months ago

Introduced in [19897], updated in [31611].

#6 @audrasjb
12 months ago

  • Owner set to audrasjb
  • Status changed from new to accepted

Self assigning for commit.

#7 @audrasjb
12 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55689:

Editor: Improve the tag field loading spinner alignment.

This changeset improves the loading spinner alignment of the Classic Editor's tag field.

Follow-up to [19897], [31611].

Props Presskopp, SergeyBiryukov, audrasjb.
Fixes #58136.

#8 @sabernhardt
12 months ago

  • Focuses css added
  • Keywords commit removed

In multisite, you can also find an autocomplete Username field when adding an existing user to a site (visiting Sites -> All Sites in the side menu, then selecting a site to edit, then clicking the Users 'tab' link).

[55689] works there, too :)

Note: See TracTickets for help on using tickets.