Use strict type comparison in wp-admin/includes/class-wp-ms-sites-list-table.php

[mujuonly]

Use === instead of == in wp-admin/includes/class-wp-ms-sites-list-table.php

Use === instead of == in wp-admin/includes/class-wp-ms-sites-list-table.php

Trac ticket: https://core.trac.wordpress.org/ticket/58139

[audrasjb]

Thanks for opening this ticket and for the PR.

I have not looked deeply into this, but are we sure that $blog['deleted'], $blog['archived'] and $blog['spam'] are string type? Shouldn't we cast them into a string?

[jankyz]

Even if those are strings this condition checks if each has value '1' it means true

cast to (string) won't change anything here

<?php
if ( '1' == $blog['deleted'] ) {}

we can simply reverse the condition and use ===

<?php
if ( $blog['deleted'] === '1' ) {}

[krupalpanchal]

Replying to jankyz:

Even if those are strings this condition checks if each has value '1' it means true

cast to (string) won't change anything here

<?php
if ( '1' == $blog['deleted'] ) {}

we can simply reverse the condition and use ===

<?php
if ( $blog['deleted'] === '1' ) {}

It is good to use the Yoda condition here according to standards.

[SergeyBiryukov]

Thanks for the PR! I have confirmed that these values are indeed strings as returned from get_sites() via WP_MS_Sites_List_Table::prepare_items().

They match the WP_Site class properties of the same name, which are also defined as numeric strings, '1' or '0', for compatibility reasons.

[SergeyBiryukov]

In 55656:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-ms-sites-list-table.php.

Includes minor code layout fixes for better readability.

Follow-up to [12603], [32630], [32755], [46441].

Props mujuonly, audrasjb, jankyz, krupalpanchal, SergeyBiryukov.
Fixes #58139.

Thanks for the PR! Merged in r55656.