WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#58149 closed defect (bug) (fixed)

Twenty Nineteen: edit comment navigation text for translations

Reported by: sabernhardt's profile sabernhardt Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

To hide "Comments" on screens narrower than 768px, it was separated from the "Previous" or "Next" text string. This can result in faulty translations, such as "Suivant Commentaires" in French. Other languages might only have one word when the phrase is combined, too.

Steps to follow:

  1. Activate Twenty Nineteen theme.
  2. Go to Discussion Settings, toggle the "Break comments into pages" option on, and reduce that number to five (or fewer) comments per page.
  3. Publish a post, and add several (approved) comments to it. You need at least three pages of comments.
  4. View the post on a screen larger than 782 pixels, and scroll to the comments section. Click the Previous Comments link so you have both the Previous and Next links.
  5. If you started in English, go to General Settings and change the language. Then refresh the post, on its second page of comments.

Attachments (2)

Twenty-Nineteen-comments-navigation-French.png​ (7.4 KB) - added by sabernhardt 2 years ago.
comments navigation links in French
Capture d’écran 2023-04-18 à 10.13.37.png​ (334.9 KB) - added by audrasjb 2 years ago.
After patch, in fr_FR: everything works fine (the string is not translated yet, just wanted to check we're not going to break anything ;)

Download all attachments as: .zip

Change History (8)

@sabernhardt
2 years ago

comments navigation links in French

This ticket was mentioned in ​PR #4339 on ​WordPress/wordpress-develop by ​@sabernhardt.
2 years ago #1

  • Keywords has-patch added

Combine text strings for "Previous Comments" and "Next Comments" links. The span tags are included in the translation to give more control over what is hidden on small screens.

Trac ticket: https://core.trac.wordpress.org/ticket/58149

#2 @audrasjb
2 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 6.3

Thank you @sabernhardt this indeed makes a big difference for translators!

#3 @audrasjb
2 years ago

  • Keywords commit added; needs-testing removed

I tested the patch and while it makes no difference in en_US, it is now possible for translators to change the words order. Also, the translator comment is very welcome.

#4 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

@audrasjb
2 years ago

After patch, in fr_FR: everything works fine (the string is not translated yet, just wanted to check we're not going to break anything ;)

#5 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55655:

Twenty Nineteen: Fix a translation issue in Comments navigation text.

This changeset combines text strings for "Previous Comments" and "Next Comments" links to ensure translators can control word order in each string. The span tags are included in the translation to give more control over what is hidden on small screens.

Props sabernhardt.
Fixes #58149.

Note: See TracTickets for help on using tickets.