Use is_main_site() in WP_MS_Sites_List_Table::handle_row_actions()

[SergeyBiryukov]

There is a conditional in WP_MS_Sites_List_Table::handle_row_actions():

if ( get_network()->site_id !== (int) $blog['blog_id'] )

For better readability, I think it can be replaced with:

if ( ! is_main_site( $blog['blog_id'] ) )

That would also be more consistent with WP_MS_Sites_List_Table::column_cb(), which already uses is_main_site() for a similar check as of [25125].

[spacedmonkey]

+1 I like this.

Trac ticket: https://core.trac.wordpress.org/ticket/58150

[ecorica]

Hello,

I'm at the contributor day in Paris and I pushed my first patch :)

[SergeyBiryukov]

Replying to ecorica:

I'm at the contributor day in Paris and I pushed my first patch :)

Looks great, thank you! :)

[SergeyBiryukov]

In 55666:

Networks and Sites: Simplify the check for main site on Network Admin → Sites screen.

This replaces a site ID comparison when displaying action links in WP_MS_Sites_List_Table::handle_row_actions() with a dedicated function call, is_main_site(), for clarity.

Follow-up to [13918], [25125], [26120], [32644], [38814].

Props ecorica, spacedmonkey, SergeyBiryukov.
Fixes #58150.

Thanks for the PR! Merged in r55666.

[SergeyBiryukov]

In 55672:

Networks and Sites: Use is_main_site() in a few more places.

This updates some more instances of comparing site IDs on Sites and Users screens in network admin to use is_main_site() for clarity.

Follow-up to [12603], [13918], [22064], [38814], [41131], [55666].

See #58150.